Guard crypto XML XSLT tests on dynamic code support#128820
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Co-authored-by: vcsjones <361677+vcsjones@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix XSLT tests for tvos-arm64 build failure
Guard crypto XML XSLT tests on dynamic code support
May 31, 2026
vcsjones
approved these changes
May 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates XSLT-related System.Security.Cryptography.Xml tests to skip on platforms without dynamic code support, matching the capability required by XslCompiledTransform before these tests can reach their intended cryptographic failure assertions.
Changes:
- Replaces
[Fact]with[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]for three XSLT security tests. - Keeps the existing expected
CryptographicExceptioncoverage on platforms where reflection emit/dynamic code is supported.
Show a summary per file
| File | Description |
|---|---|
src/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs |
Guards the signed XML encrypted-data XSLT test on reflection emit support. |
src/libraries/System.Security.Cryptography.Xml/tests/EncryptedXmlTests.cs |
Guards two encrypted XML XSLT transform tests on reflection emit support. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
kotlarmilos
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cryptography XML XSLT tests fail on tvOS arm64 because XSLT requires dynamic code support, and that platform throws
NotSupportedExceptionbefore the tests reach their expected crypto failure path.[Fact]to the existing dynamic-code guard:SignedXml_EncryptedDataWithInfiniteXslTransformEncryptedKey_InfiniteLoopXsltTransformEncryptedXml_BillionLaughsXsltTransform