arm64: Add SVE ptrue reuse pass after lowering#128844
Open
jonathandavies-arm wants to merge 1 commit into
Open
arm64: Add SVE ptrue reuse pass after lowering#128844jonathandavies-arm wants to merge 1 commit into
jonathandavies-arm wants to merge 1 commit into
Conversation
Contributor
jonathandavies-arm
commented
Jun 1, 2026
jonathandavies-arm
commented
- Reuses equivalent ptrue producing nodes within a block via a mask temp
- Reuses equivalent ptrue-producing nodes within a block via a mask temp
github-actions
Bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
| m_pLowering->Run(); | ||
|
|
||
| #if defined(TARGET_ARM64) && defined(FEATURE_MASKED_HW_INTRINSICS) | ||
| DoPhase(this, PHASE_ARM64_CONSTANT_MASK_REUSE, &Compiler::fgOptimizeConstantMaskReuse); |
Member
There was a problem hiding this comment.
nit, if we do this it should likely be just PHASE_CONSTANT_REUSE, we have several cases of "low cost constants" that get unnecessarily rematerialized across all architectures, including cases like zero and allbitsset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.