Enable LibraryImportGenerator.Tests on BSD/SunOS#129185
Conversation
|
Upstream PR dotnet/arcade#16995. |
|
short: fine but maybe move the long: From my FreeBSD 15.0: cmake manual (4.3.3) still shows using but if it works, then it works 🤷 |
|
The error we were getting was different: dotnet/arcade#16995 (comment) emerging from TOOLCHAIN was null. Note that TOOLCHAIN is our own variable in this context.
Updated. 👍 Mostly it's backwards compatible but if it gets too old, then it ends. up using fallback/shim code on newer platform ( |
|
Timeout failures are unrelated. |
|
Any chance this can get merged soon? Without |
|
/ba-g the build timeouts are unrelated to this change and are happening on multiple PRs. |
These should be fine with bootstrap test build. We need to set TOOLCHAIN instead of triplet so DNNE proj gets target-triplet set by convention. --------- Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
These should be fine with bootstrap test build. We need to set TOOLCHAIN instead of triplet so DNNE proj gets target-triplet set by convention.