[release/10.0] Update Alpine infra images to 3.24 - #129867
Conversation
Servicing port of #129824. Bump Alpine-based Helix and build container image references from 3.23 to 3.24 on release/10.0: - eng/pipelines/common/templates/pipeline-with-resources.yml (build container) - eng/pipelines/coreclr/templates/helix-queues-setup.yml (musl x64/arm32/arm64) - eng/pipelines/installer/helix-queues-setup.yml (musl x64/arm64) - eng/pipelines/libraries/helix-queues-setup.yml (musl x64/arm64) Tags verified present in the MCR registry (alpine-3.24-amd64, alpine-3.24-helix-amd64/-arm32v7/-arm64v8). release/10.0 does not pin digests for these references, so the unpinned format is preserved; the musl entries in helix-platforms.yml are not present on this branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
Updates release/10.0 pipeline and Helix queue configuration to move Alpine-based infra image references from Alpine 3.23 to Alpine 3.24, keeping the existing (unpinned) tag style while aligning the musl build/test legs with the newer Alpine baseline.
Changes:
- Updated the linux-musl x64 innerloop build container tag to
alpine-3.24-amd64. - Updated Helix queue labels and corresponding prereqs image tags for Alpine musl (x64/arm32/arm64) to
Alpine.324/alpine-3.24-*. - Removed remaining Alpine 3.23 references from the modified pipeline templates (verified within the changed files).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/common/templates/pipeline-with-resources.yml | Bumps linux musl x64 dev innerloop container image to Alpine 3.24. |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Updates CoreCLR Helix musl queue labels and prereqs image tags from 3.23 to 3.24 (x64/arm32/arm64). |
| eng/pipelines/installer/helix-queues-setup.yml | Updates Installer Helix musl queue labels and prereqs image tags from 3.23 to 3.24 (x64/arm64). |
| eng/pipelines/libraries/helix-queues-setup.yml | Updates Libraries Helix musl queue labels and prereqs image tags from 3.23 to 3.24 (x64/arm64). |
|
The likely regression observed in main needs to be resolved first: #129876 |
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "050adea8fc1016ff3cbde74edc5453e8fdad11be",
"last_dispatched_base_ref": "release/10.0",
"last_dispatched_base_sha": "bee7e39da8fc9befed4bb154bb74a4d8a180f102",
"last_reviewed_commit": "050adea8fc1016ff3cbde74edc5453e8fdad11be",
"last_reviewed_base_ref": "release/10.0",
"last_reviewed_base_sha": "bee7e39da8fc9befed4bb154bb74a4d8a180f102",
"last_recorded_worker_run_id": "29677703380",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "050adea8fc1016ff3cbde74edc5453e8fdad11be",
"review_id": 4730521413
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: This is a servicing port of #129824 to release/10.0, updating the Alpine-based infrastructure image references from Alpine 3.23 to Alpine 3.24. Alpine 3.23 is nearing the point where the newer 3.24 is the appropriate onboarding target, keeping CI on a supported Alpine version.
Approach: The change is a purely mechanical string update across four pipeline YAML files. It bumps the build container image (alpine-3.23-amd64 → alpine-3.24-amd64) and the Helix musl x64/arm32/arm64 queue names and images (Alpine.323/alpine-3.23-helix-* → Alpine.324/alpine-3.24-helix-*). No digest pinning is introduced, matching the existing unpinned style on release/10.0, and helix-platforms.yml is correctly left untouched since it has no Alpine entries on this branch.
Summary: LGTM. The diff is complete and internally consistent: I verified no stray alpine-3.23 or Alpine.323 references remain under eng/, and every queue-name/image pair was updated together. This is a low-risk, well-scoped infrastructure version bump appropriate for servicing. Correctness ultimately depends on the alpine-3.24-* MCR image tags and the Alpine.324.* Helix queues actually existing/being provisioned; the PR description states these tags were verified against the MCR registry, and CI on the branch will confirm the Helix queues resolve. No code or actionable issues found.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 36 AIC · ⌖ 14.4 AIC · ⊞ 10K
|
#129876 turned out to be due to a different issue so this is fine. |
|
Infrastructure-only change, servicing approved |
Summary
Servicing port of #129824. Update Alpine-based infrastructure image references from Alpine 3.23 to Alpine 3.24 on
release/10.0.alpine-3.23-amd64alpine-3.24-amd64Alpine.323/alpine-3.23-helix-amd64Alpine.324/alpine-3.24-helix-amd64Alpine.323/alpine-3.23-helix-arm32v7Alpine.324/alpine-3.24-helix-arm32v7Alpine.323/alpine-3.23-helix-arm64v8Alpine.324/alpine-3.24-helix-arm64v8Files changed:
eng/pipelines/common/templates/pipeline-with-resources.yml,eng/pipelines/coreclr/templates/helix-queues-setup.yml,eng/pipelines/installer/helix-queues-setup.yml,eng/pipelines/libraries/helix-queues-setup.yml.Differences from the main PR (#129824)
helix-platforms.ymlis not modified — it has no Alpine entries onrelease/10.0.release/10.0(only the version changed).Validation
The
dotnet/versionsimage-info JSON is unreliable (see dotnet/docker-tools#2142), so the exact tags were verified directly against the MCR registry tag list:alpine-3.24-amd64alpine-3.24-helix-amd64alpine-3.24-helix-arm32v7alpine-3.24-helix-arm64v8Lifecycle
Reference: https://github.com/dotnet/runtime/blob/main/docs/project/os-onboarding.md
Note
This PR description was AI/Copilot-generated.