-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add compile-time and run-time methods to obtain Vector<T> byte length #130023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snickolls-arm
wants to merge
11
commits into
dotnet:main
Choose a base branch
from
snickolls-arm:vectort-length-helpers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a2b849c
Add compile-time and run-time methods to obtain Vector<T> byte length
snickolls-arm 39c1102
Move evalVectorCount to importercalls.cpp
snickolls-arm f5bbddb
Merge remote-tracking branch 'origin/main' into vectort-length-helpers
snickolls-arm 9415fde
Merge branch 'main' into vectort-length-helpers
snickolls-arm 2e997fb
Extend getBuiltinClass to be able to retrieve Vector<T>
snickolls-arm e55e98d
Merge branch 'main' into vectort-length-helpers
snickolls-arm 424ec4f
Merge remote-tracking branch 'origin/main' into vectort-length-helpers
snickolls-arm 7f3b13b
Merge remote-tracking branch 'origin/main' into vectort-length-helpers
snickolls-arm 72d66f9
Merge branch 'main' into vectort-length-helpers
snickolls-arm 60fda72
Merge branch 'main' into vectort-length-helpers
snickolls-arm 044de64
Merge branch 'main' into vectort-length-helpers
snickolls-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to return an open generic type to the JIT. Does it make sense to query properties about the open generic type? Would it make more sense to return some particular instantiation, like
Vector<byte>?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found that it's enough to do this to cover all that I want to do, that is just call
getClassSize. It works because the generic type, and all instantiations of,Vector<T>should have the same size, set by this function:runtime/src/coreclr/vm/methodtablebuilder.cpp
Line 1189 in dad8c23
But yes, maybe this handle isn't useful for much beyond that. Am I leaving a pitfall by not providing an instantiated handle? Instantiating the class would still be fine for my use case.