Revert "Work around CS9363 for nameof of pointer-typed fields"

[akoeplinger]

This reverts commit 22c452b. The upstream roslyn fix is now in a compiler used by the repo.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR updates System.Runtime reflection tests to use nameof(...) again for pointer-typed and function-pointer-typed fields, removing the prior string-literal workaround in the test data now that the compiler issue is no longer needed.

Changes:

• Replace hard-coded field name strings ("s_intPtr", "intPtr", "s_fcnPtr", etc.) with nameof(...) for pointer and function pointer fields in GetValue / SetValue test data.

[github-actions]

Copilot Code Review

Holistic Assessment

Motivation: Justified — the PR reverts a temporary workaround (string literals instead of nameof) that was needed due to Roslyn bug CS9363. The upstream fix (dotnet/roslyn#84325) has now flowed into the repo's compiler, making the workaround unnecessary.

Approach: Correct — this is a clean revert restoring the idiomatic nameof(Type.Field) pattern, which provides compile-time verification of field names. The change is test-only and carries zero risk to production code.

Summary: ✅ LGTM. All 8 replacements correctly restore nameof(...) for pointer-typed fields (s_intPtr, intPtr, s_fcnPtr, fcnPtr, s_intPtr_Set, s_fcnPtr_Set). I verified each field name matches the actual declarations in MyStruct and MyStructWithFunctionPointers. No behavioral change — nameof produces the identical string value as the literals it replaces.

---

Detailed Findings

Detailed Findings

✅ Correctness — All nameof references match declared field names

Verified the struct definitions:

• MyStruct.s_intPtr → public unsafe static int* s_intPtr ✓
• MyStruct.intPtr → public unsafe int* intPtr ✓
• MyStruct.s_intPtr_Set → public unsafe static int* s_intPtr_Set ✓
• MyStructWithFunctionPointers.s_fcnPtr → public unsafe static delegate*<void> s_fcnPtr ✓
• MyStructWithFunctionPointers.fcnPtr → public unsafe delegate*<void> fcnPtr ✓
• MyStructWithFunctionPointers.s_fcnPtr_Set → public unsafe static delegate*<void> s_fcnPtr_Set ✓

✅ Scope — Change is minimal and focused

Only one file modified, only the workaround lines are reverted, no unrelated changes included.

Note

This review was created by GitHub Copilot.

Generated by Code Review for issue #130308 · ● 10.3M · ◷