Add runtime-async varargs testcase and treat vararg Task-returning methods as normal methods

[Copilot]

__arglist (vararg calling convention) is an unsupported combination with runtime-async. Previously an async MethodImpl vararg method could produce a broken async thunk (crash/UB), and there was no coverage for vararg Task/ValueTask methods. The goal is "don't crash on scenarios that used to work."

Runtime change (src/coreclr/vm/methodtablebuilder.cpp)

In EnumerateClassMethods, before async-variant creation, classify vararg Task/ValueTask-returning methods deterministically:

• Ordinary (non-async) vararg Task/ValueTask method → re-classified as NormalMethod, so no async variant is generated and it behaves exactly as before.
• async MethodImpl vararg method → throws IDS_EE_VARARG_NOT_SUPPORTED (TypeLoadException) at type load instead of emitting a broken thunk.

// Vararg methods are not allowed to be marked MethodImpl.Async
// and even when they return Tasks they are still treated as NormalMethod.
if (returnKind != MethodReturnKind::NormalMethod)
{
    if (MetaSig::IsVarArg(Signature(pMemberSignature, cMemberSignature)))
    {
        if (IsMiAsync(dwImplFlags))
            BuildMethodTableThrowException(IDS_EE_VARARG_NOT_SUPPORTED);
        else
            returnKind = MethodReturnKind::NormalMethod;
    }
}

Test (src/tests/async/varargs/varargs.il + varargs.ilproj)

Authored in IL because Roslyn rejects __arglist in async methods under runtime-async (CS9328).

• Ordinary vararg Task/ValueTask methods (using ArgIterator): validated via direct call and via await from a runtime-async wrapper.
• async vararg Task/ValueTask methods: asserting the declaring type fails to load with TypeLoadException.
• Vararg call sites are isolated in dedicated helpers and each Fact is guarded with OperatingSystem.IsWindows(), since managed varargs are Windows-only (compFeatureVarArg, src/coreclr/jit/target.h); non-Windows platforms skip without jitting a vararg instruction.

Validation notes

The positive vararg paths cannot be exercised on Linux (managed __arglist is unsupported off-Windows — the JIT emits BADCODE), hence the Windows runtime gating; those paths depend on Windows CI for full validation. The runtime fix compiles cleanly.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

[VSadov]

@copilot there are test failures like:

System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<Int32> Async2Varargs.OrdinaryTaskVararg(Int32, ...)'.
   at Async2Varargs.CallOrdinaryTaskVararg()
   at Async2Varargs.DirectCallTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor90|0_91(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
02:20:30.566 Failed test: _varargs_varargs::Async2Varargs.DirectCallTaskVarargTest()
02:20:30.572 Running test: _varargs_varargs::Async2Varargs.DirectCallValueTaskVarargTest()
System.MissingMethodException: Method not found: 'System.Threading.Tasks.ValueTask`1<Int32> Async2Varargs.OrdinaryValueTaskVararg(Int32, ...)'.
   at Async2Varargs.CallOrdinaryValueTaskVararg()
   at Async2Varargs.DirectCallValueTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor91|0_92(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
02:20:30.574 Failed test: _varargs_varargs::Async2Varargs.DirectCallValueTaskVarargTest()
02:20:30.580 Running test: _varargs_varargs::Async2Varargs.AwaitTaskVarargTest()
System.AggregateException: One or more errors occurred. (Method not found: 'System.Threading.Tasks.Task`1<Int32> Async2Varargs.OrdinaryTaskVararg(Int32, ...)'.)
 ---> System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<Int32> Async2Varargs.OrdinaryTaskVararg(Int32, ...)'.
   at Async2Varargs.AwaitOrdinaryTaskVararg()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at Async2Varargs.AwaitTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor92|0_93(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
02:20:30.593 Failed test: _varargs_varargs::Async2Varargs.AwaitTaskVarargTest()
02:20:30.599 Running test: _varargs_varargs::Async2Varargs.AwaitValueTaskVarargTest()
System.AggregateException: One or more errors occurred. (Method not found: 'System.Threading.Tasks.ValueTask`1<Int32> Async2Varargs.OrdinaryValueTaskVararg(Int32, ...)'.)
 ---> System.MissingMethodException: Method not found: 'System.Threading.Tasks.ValueTask`1<Int32> Async2Varargs.OrdinaryValueTaskVararg(Int32, ...)'.
   at Async2Varargs.AwaitOrdinaryValueTaskVararg()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at Async2Varargs.AwaitValueTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor93|0_94(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
02:20:30.608 Failed test: _varargs_varargs::Async2Varargs.AwaitValueTaskVarargTest()
02:20:30.613 Running test: _varargs_varargs::Async2Varargs.AsyncVarargTaskFailsTest()
System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<Int32> AsyncTaskVarargs.AsyncTaskVararg(Int32, ...)'.
   at Async2Varargs.TriggerAsyncTaskVararg()
   at Async2Varargs.AsyncVarargTaskFailsTest()
   at Program.<<Main>$>g__TestExecutor94|0_95(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
02:20:30.616 Failed test: _varargs_varargs::Async2Varargs.AsyncVarargTaskFailsTest()
02:20:30.621 Running test: _varargs_varargs::Async2Varargs.AsyncVarargValueTaskFailsTest()
System.MissingMethodException: Method not found: 'System.Threading.Tasks.ValueTask`1<Int32> AsyncValueTaskVarargs.AsyncValueTaskVararg(Int32, ...)'.
   at Async2Varargs.TriggerAsyncValueTaskVararg()
   at Async2Varargs.AsyncVarargValueTaskFailsTest()
   at Program.<<Main>$>g__TestExecutor95|0_96(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
02:20:30.623 Failed test: _varargs_varargs::Async2Varargs.AsyncVarargValueTaskFailsTest()
02:20:30.630 Running test: async/varying-yields/varying-yields-task/varying-yields-task.dll

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[Copilot]

@copilot there are test failures like:

System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<Int32> Async2Varargs.OrdinaryTaskVararg(Int32, ...)'.

...

Fixed in b7c... — this was an ILAsm authoring bug in the test, not a runtime issue.

The four vararg method definitions were written as OrdinaryTaskVararg(int32 first, ...), placing ... in the parameter list but omitting the vararg calling-convention keyword. ILAsm silently assembles that as the default calling convention (sig byte 0x00), so MetaSig::IsVarArg returned false and the runtime reclassification never ran. Meanwhile the call sites were emitted with the vararg calling convention, so CompareMethodSigs saw a calling-convention mismatch → MissingMethodException.

The fix moves vararg to the calling-convention position (after static, before the return type) and drops the , ... from the definitions' parameter lists; call sites are unchanged. I verified locally on Linux via a probe (forcing the Windows-gated bodies to run) that with the corrected IL:

• ordinary vararg Task/ValueTask methods are reclassified to NormalMethod and resolve correctly (the MissingMethodException is gone), and
• the async vararg types now fail to load with TypeLoadException as intended.

The vararg call still throws InvalidProgramException on Linux (managed varargs are Windows-only), which is exactly why each Fact is guarded with OperatingSystem.IsWindows(); the positive call paths run on Windows CI.

Note

This comment was generated by GitHub Copilot.

[VSadov]

@copilot there are still failures (perhaps new ones) in the last iteration:

System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<Int32> System.Threading.Tasks.Task.FromResult(!!0)'.
   at Async2Varargs.OrdinaryTaskVararg(Int32 first)
   at Async2Varargs.CallOrdinaryTaskVararg()
   at Async2Varargs.DirectCallTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor93|0_94(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
21:37:52.019 Failed test: _varargs_varargs::Async2Varargs.DirectCallTaskVarargTest()
21:37:52.023 Running test: _varargs_varargs::Async2Varargs.DirectCallValueTaskVarargTest()
21:37:52.027 Passed test: _varargs_varargs::Async2Varargs.DirectCallValueTaskVarargTest()
21:37:52.030 Running test: _varargs_varargs::Async2Varargs.AwaitTaskVarargTest()
System.AggregateException: One or more errors occurred. (Method not found: 'System.Threading.Tasks.Task`1<Int32> System.Threading.Tasks.Task.FromResult(!!0)'.)
 ---> System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task`1<Int32> System.Threading.Tasks.Task.FromResult(!!0)'.
   at Async2Varargs.OrdinaryTaskVararg(Int32 first)
   at Async2Varargs.AwaitOrdinaryTaskVararg()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at Async2Varargs.AwaitTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor95|0_96(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
21:37:52.061 Failed test: _varargs_varargs::Async2Varargs.AwaitTaskVarargTest()
21:37:52.065 Running test: _varargs_varargs::Async2Varargs.AwaitValueTaskVarargTest()
System.Exception: AwaitValueTaskVarargTest returned the wrong value
   at Async2Varargs.AwaitValueTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor96|0_97(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[Copilot]

@copilot there are still failures (perhaps new ones) in the last iteration:

...

Fixed both failures — both were IL-authoring bugs in the test, not runtime issues.

1. **Method not found: Task1 Task.FromResult(!!0)** — the callee wrote the generic method's return type with the instantiation (Task1<int32>) instead of the method type parameter (Task1<!!0>). Generic method resolution compares the uninstantiated signature, so it never matched. Corrected the return type to Task1<!!0> (the <int32> instantiation stays on the call).

2. AwaitValueTaskVarargTest returned the wrong value — the vararg call site was emitted directly inside the runtime-async method, where the async frame's special layout corrupts the arglist cookie. The file's stated design was to keep vararg call sites in isolated helpers, so I moved them into non-async MakeOrdinary{Task,ValueTask}Vararg helpers; the async AwaitOrdinary*Vararg methods now just await the returned Task/ValueTask.

Verified varargs.dll assembles and confirmed both signature/structure changes via an ildasm roundtrip.

Note

This comment was generated by GitHub Copilot.

[VSadov]

@copilot there is a failure in one of the scenarios:

03:04:26.304 Running test: _varargs_varargs::Async2Varargs.DirectCallTaskVarargTest()
03:04:26.311 Passed test: _varargs_varargs::Async2Varargs.DirectCallTaskVarargTest()
03:04:26.317 Running test: _varargs_varargs::Async2Varargs.DirectCallValueTaskVarargTest()
03:04:26.322 Passed test: _varargs_varargs::Async2Varargs.DirectCallValueTaskVarargTest()
03:04:26.328 Running test: _varargs_varargs::Async2Varargs.AwaitTaskVarargTest()
03:04:26.338 Passed test: _varargs_varargs::Async2Varargs.AwaitTaskVarargTest()
03:04:26.344 Running test: _varargs_varargs::Async2Varargs.AwaitValueTaskVarargTest()
System.Exception: AwaitValueTaskVarargTest returned the wrong value
   at Async2Varargs.AwaitValueTaskVarargTest()
   at Program.<<Main>$>g__TestExecutor96|0_97(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
03:04:26.590 Failed test: _varargs_varargs::Async2Varargs.AwaitValueTaskVarargTest()
03:04:26.597 Running test: _varargs_varargs::Async2Varargs.AsyncVarargTaskFailsTest()
03:04:26.599 Passed test: _varargs_varargs::Async2Varargs.AsyncVarargTaskFailsTest()
03:04:26.605 Running test: _varargs_varargs::Async2Varargs.AsyncVarargValueTaskFailsTest()
03:04:26.607 Passed test: _varargs_varargs::Async2Varargs.AsyncVarargValueTaskFailsTest()

Can this be a test issue or it is a real product bug?

[Copilot]

@copilot there is a failure in one of the scenarios:

...

My read: this is a real product bug, not a test bug (the expected value is correct: 100+30+7 = 137).

The four scenarios now isolate the variable cleanly:

• DirectCallValueTaskVarargTest passes → OrdinaryValueTaskVararg computes the sum correctly and the returned ValueTask<int> is read correctly via .Result from a local.
• AwaitTaskVarargTest passes → the structurally identical await path works when the awaitable is a reference type (Task<int>).
• AwaitValueTaskVarargTest fails, and the vararg call site is no longer inside the async method — it's isolated in the non-async MakeOrdinaryValueTaskVararg helper. So the async method literally just does call Make...(); call AsyncHelpers.Await<int>(ValueTask<int>).

So the only thing unique to the failing case is: awaiting a synchronously-completed ValueTask<int> (_obj == null, so Await<T> returns task._result directly — AsyncHelpers.cs:123-126) that is passed by value into the runtime-async Await method, where that struct came out of a vararg callee's return buffer (forwarded through MakeOrdinaryValueTaskVararg's ret).

The symptom points at the culprit: it returns a wrong value rather than throwing/crashing. If _obj were being misread we'd take the Task/IValueTaskSource branch and get an exception; getting a wrong scalar back instead means the ValueTask<int> struct argument's _result field is being materialized from the wrong location — i.e. struct-by-value arg handling on this path.

Two cheap experiments to pin it down (both need Windows since managed varargs are Windows-only):

1. Make MakeOrdinaryValueTaskVararg materialize the struct into a local and reload before ret (mirroring the passing DirectCall shape). If that fixes it, the bug is in forwarding a vararg call's struct return buffer straight into the caller's return.
2. Add a control that awaits a ValueTask<int> produced by a non-vararg helper (same new ValueTask<int>(x)). If that also fails, the bug is the runtime-async by-value struct-arg path and is unrelated to varargs; if it passes, it's specific to the vararg return-buffer interaction.

I can't run either here (these paths throw InvalidProgramException on Linux, hence the IsWindows gate). If you'd like, I can add the non-vararg control case and the local-materialization variant so the next Windows CI run disambiguates it directly.

Note

This comment was generated by GitHub Copilot.