-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add ILLink coverage for unused virtual method annotations #130640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-ilink-warnings-unused-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−0
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b6609f2
Initial plan
Copilot 860048e
Add ILLink unused annotation regression coverage
Copilot 6c3c3b7
Merge branch 'main' into copilot/fix-ilink-warnings-unused-code
jtschuster c60ab0a
Add UnexpectedWarning annotations for analyzer-only IL2046/IL2092 on …
Copilot 51884f2
Update UnexpectedWarning reason strings to 'Analyzer does not track r…
Copilot 5bc07dc
Change UnexpectedWarning to ExpectedWarning for analyzer-only IL2046/…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
90 changes: 90 additions & 0 deletions
90
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/UnusedVirtualMethodAnnotations.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // Copyright (c) .NET Foundation and contributors. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using System; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using Mono.Linker.Tests.Cases.Expectations.Assertions; | ||
| using Mono.Linker.Tests.Cases.Expectations.Helpers; | ||
|
|
||
| namespace Mono.Linker.Tests.Cases.DataFlow | ||
| { | ||
| [SkipKeptItemsValidation] | ||
| [ExpectedNoWarnings] | ||
| class UnusedVirtualMethodAnnotations | ||
| { | ||
| [UnconditionalSuppressMessage("Test", "IL2026")] | ||
| public static void Main() | ||
| { | ||
| _ = typeof(TypeOnlyImplementation); | ||
|
|
||
| IUsed used = new UsedImplementation(); | ||
| used.Method(typeof(object)); | ||
|
|
||
| IPartiallyUsed partiallyUsed = new PartiallyUsedImplementation(); | ||
| partiallyUsed.Method(typeof(object)); | ||
| } | ||
|
|
||
| [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] | ||
| interface IUnused | ||
| { | ||
| [RequiresUnreferencedCode(nameof(Method))] | ||
| void Method([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] Type type); | ||
| } | ||
|
|
||
| class UnusedImplementation : IUnused | ||
| { | ||
| [ExpectedWarning("IL2046", Tool.Analyzer, "Analyzer does not track reachability")] | ||
| [ExpectedWarning("IL2092", Tool.Analyzer, "Analyzer does not track reachability")] | ||
| public void Method(Type type) { } | ||
| } | ||
|
|
||
| [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] | ||
| interface ITypeOnly | ||
| { | ||
| [RequiresUnreferencedCode(nameof(Method))] | ||
| void Method([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] Type type); | ||
| } | ||
|
|
||
| class TypeOnlyImplementation : ITypeOnly | ||
| { | ||
| [ExpectedWarning("IL2046", Tool.Analyzer, "Analyzer does not track reachability")] | ||
| [ExpectedWarning("IL2092", Tool.Analyzer, "Analyzer does not track reachability")] | ||
| public void Method(Type type) { } | ||
| } | ||
|
|
||
| [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] | ||
| interface IUsed | ||
| { | ||
| [RequiresUnreferencedCode(nameof(Method))] | ||
| void Method([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] Type type); | ||
| } | ||
|
|
||
| class UsedImplementation : IUsed | ||
| { | ||
| [ExpectedWarning("IL2046")] | ||
| [ExpectedWarning("IL2092")] | ||
| public void Method(Type type) { } | ||
| } | ||
|
|
||
| [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] | ||
| interface IPartiallyUsed | ||
| { | ||
| [RequiresUnreferencedCode(nameof(Method))] | ||
| void Method([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] Type type); | ||
| } | ||
|
|
||
| class PartiallyUsedImplementation : IPartiallyUsed | ||
| { | ||
| [ExpectedWarning("IL2046")] | ||
| [ExpectedWarning("IL2092")] | ||
| public void Method(Type type) { } | ||
| } | ||
|
|
||
| class UnusedImplementationOfPartiallyUsedInterface : IPartiallyUsed | ||
| { | ||
| [ExpectedWarning("IL2046", Tool.Analyzer, "Analyzer does not track reachability")] | ||
| [ExpectedWarning("IL2092", Tool.Analyzer, "Analyzer does not track reachability")] | ||
| public void Method(Type type) { } | ||
|
jtschuster marked this conversation as resolved.
|
||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the interfaces need
DAMto repro this issue? I would leave this out (or at least add a simpler test without DAM on the interface).