Skip to content

Fix concurrent Reflection.Emit TypeLoadException (#129230) #130696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steveisok wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −8
Open

Fix concurrent Reflection.Emit TypeLoadException (#129230) #130696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/coreclr/md/compiler/emit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2751,10 +2751,6 @@ HRESULT RegMeta::DefineProperty(
IfFailGo(_SetPropertyProps(*pmdProp, dwPropFlags, dwCPlusTypeFlag, pValue, cchValue, mdSetter,
mdGetter, rmdOtherMethods));
Comment on lines 2751 to 2752

// Add the <property token, typedef token> to the lookup table
if (m_pStgdb->m_MiniMd.HasIndirectTable(TBL_Property))
IfFailGo( m_pStgdb->m_MiniMd.AddPropertyToLookUpTable(*pmdProp, td) );

ErrExit:
SetCallerExternal();

Expand Down
4 changes: 0 additions & 4 deletions src/coreclr/md/compiler/regmeta_emit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,10 +1333,6 @@ HRESULT RegMeta::_DefineEvent( // Return hresult.
IfFailGo(m_pStgdb->m_MiniMd.PutString(TBL_Event, EventRec::COL_Name, pEventRec, szUTF8Event));
IfFailGo(_SetEventProps1(*pmdEvent, dwEventFlags, tkEventType));

// Add the <Event token, typedef token> to the lookup table
if (m_pStgdb->m_MiniMd.HasIndirectTable(TBL_Event))
IfFailGo( m_pStgdb->m_MiniMd.AddEventToLookUpTable(*pmdEvent, td) );

IfFailGo(UpdateENCLog(*pmdEvent));

ErrExit:
Expand Down
Loading