Skip to content

[wasi] Add CoreCLR-WASI corehost (wasihost)#130816

Merged
lewing merged 12 commits into
dotnet:mainfrom
lewing:lewing-wasi-corehost
Jul 17, 2026
Merged

[wasi] Add CoreCLR-WASI corehost (wasihost)#130816
lewing merged 12 commits into
dotnet:mainfrom
lewing:lewing-wasi-corehost

Conversation

@lewing

@lewing lewing commented Jul 15, 2026

Copy link
Copy Markdown
Member

[wasi] Add CoreCLR-WASI corehost (wasihost)

Summary

Adds a proper, statically-linked corehost for the CoreCLR-WASI library-test leg, under
src/native/corehost/wasihost/, mirroring browserhost and the static apphost. This lets the
CoreCLR-WASI library-test leg run on a shipping host archive (libWasiHost.a) instead of
relinking the coreclr-internal corerun. corerun keeps its role for CoreCLR runtime tests.

This is the foundation host for the CoreCLR-WASI library-test leg (#130745) — per @pavelsavara's
review there ("we should manufacture proper corehost for this ... similar as browserhost or apphost -
statically linked").

What it does

src/native/corehost/wasihost/ produces libWasiHost.a (OUTPUT_NAME WasiHost), a self-contained
STATIC host archive installed to sharedFramework. It is linked per-app (whole-archive, so
main/_start are pulled) by the CoreCLR-WASI app builder together with the runtime-pack static
libraries and the app-generated P/Invoke callhelpers.

The host is thin (browserhost-style, not hostfxr/hostpolicy):

  • Builds the CoreCLR init properties (TPA/APP_PATHS/NATIVE_DLL_SEARCH_DIRECTORIES) from CORE_ROOT.
  • Sets host_runtime_contract.pinvoke_override to the app-generated callhelpers_pinvoke_override.
    coreclr_initialize forwards this to PInvokeOverride::SetPInvokeOverride(..., RuntimeConfiguration)
    — the sanctioned host↔runtime P/Invoke override interface, the same registration corerun performs
    internally. This keeps the archive self-contained (no coreclr contract.h/specstrings.h drag-in).
  • Preloads icudt.dat via a weak GlobalizationNative_LoadICUData (skipped for invariant relinks).
  • Runs coreclr_initialize / coreclr_execute_assembly with a real wasi:cli/run main().
  • Emits the WASM EXIT <n> marker under DOTNET_WASI_PRINT_EXIT_CODE=1 (until exit-with-code,
    stable in WASI 0.3, is reachable from a wasip2 target).

It reuses the corerun pal header for CORE_ROOT/TPA/path handling so assembly discovery is
byte-identical to the corerun-based host.

Build enablement / packaging

  • corehost/CMakeLists.txt: new CLR_CMAKE_TARGET_WASI branch that builds only wasihost (no
    hostmisc dependency — the archive is self-contained), so wasi no longer falls into the full
    apphost/fxr/hostpolicy branch.
  • corehost.proj: acquire the wasi-sdk and pass WASI_SDK_PATH to the native build; stage
    libWasiHost.a into the runtime pack native dir (CopyWasiNativeFiles, mirroring browser's
    CopyWasmNativeFiles).
  • eng/liveBuilds.targets: package libWasiHost.a from $(HostSharedFrameworkDir) for wasi CoreCLR
    (mirrors the browser libBrowserHost.a entry; excluded from the runtime-tests build like browser).
  • Directory.Build.props: add the libWasiHost.a platform manifest entry.

Validation

  • Builds via ./build.sh -s host.native -os wasi -c Release — 0 warnings / 0 errors; installs to
    HostSharedFrameworkDir.
  • Symbol contract verified: __main_argc_argv defined (whole-archive entry), coreclr_* and the
    C++-mangled callhelpers_pinvoke_override undefined (relink-provided), GlobalizationNative_LoadICUData
    weak, JS-interop stubs defined.
  • Relinked System.Runtime.Tests against this archive (non-invariant, full ICU) with
    wasm-component-ld → valid wasm component; under wasmtime it initializes CoreCLR, discovers all
    9930 test cases, and executes tests (a System.Tests.VersionTests subset ran 251/251 passing,
    WASM EXIT 0).

Consumer

Paired with the CoreCLR-WASI library-test leg in #130745, which will flip its per-app relink from the
corerun static archive to this host-built libWasiHost.a once this lands.

Note

This PR (code and description) was authored with GitHub Copilot.

@lewing
[wasi] Add CoreCLR-WASI corehost (wasihost)
dda5535 
Stand up a proper, statically-linked corehost for the CoreCLR-WASI
library-test leg, mirroring browserhost and the static apphost, so the
leg can run on a shipping host archive instead of relinking the
coreclr-internal corerun. corerun keeps its role for CoreCLR runtime
tests.

New src/native/corehost/wasihost/ produces libWasiHost.a (OUTPUT_NAME
WasiHost), a self-contained STATIC host archive installed to
sharedFramework. It is linked per-app (whole-archive) by
WasiApp.CoreCLR.targets together with the runtime-pack static libraries
and the app-generated P/Invoke callhelpers.

The host is thin (browserhost-style): it builds the CoreCLR init
properties from CORE_ROOT, sets host_runtime_contract.pinvoke_override
to the app-generated callhelpers_pinvoke_override (coreclr_initialize
forwards it to PInvokeOverride::SetPInvokeOverride, the same
registration corerun performs), preloads icudt.dat via a weak
GlobalizationNative_LoadICUData, and runs coreclr_initialize /
coreclr_execute_assembly with a real wasi:cli/run main(). It reuses the
corerun pal header for CORE_ROOT/TPA/path handling so assembly discovery
stays identical to the corerun-based host.

Build enablement:
- corehost/CMakeLists.txt: add a CLR_CMAKE_TARGET_WASI branch that builds
  only wasihost (no hostmisc dependency).
- corehost.proj: acquire the wasi-sdk and pass WASI_SDK_PATH to the
  native build; stage libWasiHost.a into the runtime pack native dir.
- eng/liveBuilds.targets: package libWasiHost.a from HostSharedFrameworkDir
  for wasi CoreCLR (mirrors the browser libBrowserHost.a entry).
- Directory.Build.props: add the libWasiHost.a platform manifest entry.

Foundation host for the CoreCLR-WASI library-test leg (dotnet#130745).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
Copilot AI review requested due to automatic review settings July 15, 2026 20:08
@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new CoreCLR-WASI “thin” corehost, wasihost, built as a static archive (libWasiHost.a) and packaged/staged so CoreCLR-WASI library-test apps can link against a shipping host archive (mirroring the browserhost static host model).

Changes:

  • Introduces src/native/corehost/wasihost/ (C++ host + CMake/configure glue) producing libWasiHost.a.
  • Updates corehost build wiring for WASI to build wasihost (instead of the full host stack) and stage libWasiHost.a into the runtime pack native directory.
  • Updates packaging/manifest inputs so libWasiHost.a is shipped for WASI CoreCLR (excluding the runtime-tests Helix flavor, matching browserhost handling).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/native/corehost/wasihost/wasihost.cpp New WASI CoreCLR host implementation (CORE_ROOT-based properties, runtime contract, ICU preload, execute/shutdown, exit marker).
src/native/corehost/wasihost/CMakeLists.txt Builds and installs WasiHost-Static as libWasiHost.a, reusing corerun PAL header.
src/native/corehost/wasihost/configure.cmake Generates config.h needed by shared corerun PAL header feature checks.
src/native/corehost/wasihost/config.h.in Template for generated config.h used by corerun PAL header.
src/native/corehost/corehost.proj Acquires WASI SDK for corehost build; stages libWasiHost.a into runtime pack native dir.
src/native/corehost/CMakeLists.txt Adds a WASI-specific branch to build only wasihost.
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props Adds libWasiHost.a to the platform manifest file entries for WASI.
eng/liveBuilds.targets Includes libWasiHost.a in WASI CoreCLR runtime pack inputs (excluding runtime-tests builds).

Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
@lewing
Make host_runtime_contract static in wasihost
a334566 
The runtime contract must remain valid for the process lifetime (the
runtime may call back through it any time after coreclr_initialize), and
its address is handed to the runtime via HOST_RUNTIME_CONTRACT. Storing
it in automatic storage risked use-after-scope under refactoring; make it
static, mirroring browserhost. Addresses PR review feedback.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
Copilot AI review requested due to automatic review settings July 15, 2026 20:31
@lewing
Trim wasihost comments to match repo conventions
e453f54 
The initial comments read like a design doc. Cut narration and redundant
explanation, keeping only the non-obvious rationale (contract wiring,
weak ICU symbol, mangled callhelper decl, static lifetime).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
@lewing lewing added arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm labels Jul 15, 2026
@dotnet-policy-service

dotnet-policy-service Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
Comment thread src/native/corehost/corehost.proj Outdated
Comment thread src/native/corehost/corehost.proj Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 20:38
@lewing
Address PR review: entry-arg type safety, Windows WASI_SDK_PATH, fail…
9f9119d 
…-loud copy

- wasihost.cpp: build the entry-assembly argument slice as a
  std::vector<const char*> instead of casting char** to const char**.
- corehost.proj: pass WASI_SDK_PATH to the Windows corehost build too
  (BuildCoreHostOnWindows), not just the Unix path.
- corehost.proj: drop the Exists() guard on CopyWasiNativeFiles so a
  missing libWasiHost.a fails the build (like browser's CopyWasmNativeFiles)
  rather than silently yielding an incomplete runtime pack.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
pavelsavara
pavelsavara reviewed Jul 15, 2026
View reviewed changes
Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
Comment thread src/native/corehost/wasihost/wasihost.cpp
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comment thread src/native/corehost/wasihost/wasihost.cpp
Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
Comment thread src/native/corehost/corehost.proj
Copilot AI review requested due to automatic review settings July 15, 2026 20:45
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread src/native/corehost/corehost.proj Outdated
Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
@lewing
Address review: drop wasi-dead JS interop stubs, default CORE_ROOT to…
b9e887e 
… app dir

- Remove the SystemInteropJS_* linker stubs: the wasi libcoreclr_static.a
  does not reference them (verified with llvm-nm; they exist in corerun
  only because it is shared with the browser build). Relink + run confirmed
  unaffected.
- Replace the CORE_ROOT-empty fallback (which used get_exe_path, itself
  synthesized from CORE_ROOT on wasi and thus circular) with a default to
  the entry assembly's directory, since the wasi bundle co-locates the
  framework with the app. CORE_ROOT remains an optional override.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
Copilot AI review requested due to automatic review settings July 15, 2026 20:59
@lewing
Address review: fix host-build ordering on Windows, drop dead-path refs
1b59189 
- CopyWasiNativeFiles: depend on both BuildCoreHostOnUnix and
  BuildCoreHostOnWindows (one is skipped by its HostOS condition) instead
  of $(CopyWasmNativeFilesDependsOn), which selects the Unix target for
  wasi and would leave the copy unordered against the host build on a
  Windows host.
- Replace references to the not-yet-present src/mono/wasi/build/WasiApp.CoreCLR.targets
  path (it lands with the consumer leg) with "the CoreCLR-WASI app builder".

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comment thread src/native/corehost/wasihost/wasihost.cpp
Copilot AI review requested due to automatic review settings July 15, 2026 21:05
@lewing
lewing marked this pull request as ready for review July 16, 2026 17:49
@azure-pipelines

azure-pipelines Bot commented Jul 16, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread src/native/corehost/wasihost/wasihost.cpp
@lewing
lewing requested a review from radekdoulik July 16, 2026 18:04
@lewing
Load icudt.dat from core_root, not the entry-assembly dir
ed76459 
icudt.dat is a framework asset staged with the framework (where CORE_ROOT
points), so preload it from core_root rather than app_path. These are the
same directory in the default bundle, but if CORE_ROOT is set to a
different directory than the entry assembly, loading from app_path would
miss the data and silently fall back to invariant. Addresses PR review.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
Copilot AI review requested due to automatic review settings July 16, 2026 18:05
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
@lewing
Use HOST_PROPERTY_* macros and named-field contract init
9f67ddd 
- Use the canonical HOST_PROPERTY_TRUSTED_PLATFORM_ASSEMBLIES /
  HOST_PROPERTY_APP_PATHS macros instead of string literals, matching the
  rest of corehost.
- Initialize host_runtime_contract with { sizeof, nullptr } and assign the
  used callbacks by name (like browserhost) so a future field
  add/reorder can't silently mis-wire the function pointers.

Addresses PR review.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0e95d46c-7a1d-4aee-87a7-ef681e7347cc
Copilot AI review requested due to automatic review settings July 16, 2026 18:50
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread src/native/corehost/wasihost/wasihost.cpp Outdated
@lewing lewing mentioned this pull request Jul 16, 2026
Merged
@lewing
Potential fix for pull request finding
7a6b466 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 16, 2026 21:19
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

lewing added a commit to lewing/runtime that referenced this pull request Jul 16, 2026
@lewing
Merge wasihost corehost (dotnet#130816) into CoreCLR-WASI library-tes…
d87ed72 
…t leg
lewing added a commit to lewing/runtime that referenced this pull request Jul 16, 2026
@lewing
[wasi] Consume the shipping wasihost corehost (dotnet#130816) in the …
8e32d3b 
…library-test leg

Adapt the CoreCLR-WASI library-test leg to build off the wasihost corehost
PR (dotnet#130816). Both PRs produced libWasiHost.a in the runtime pack native dir;
dotnet#130816 supplies it from a proper, statically-linked corehost
(src/native/corehost/wasihost), so this leg no longer needs to manufacture its
own host from corerun.

- corerun/CMakeLists.txt: drop the WasiHost-Static target (libWasiHost.a now
  comes from the wasihost corehost).
- corerun.cpp: revert the wasi ICU preload + weak GlobalizationNative_LoadICUData
  decl; wasihost.cpp loads icudt.dat from CORE_ROOT.
- Directory.Build.props: drop the duplicate libWasiHost.a platform-manifest entry
  (dotnet#130816 adds it in the wasi-specific section).
- WasiApp.CoreCLR.targets: the per-app link already links the pack's
  libWasiHost.a; remove the dead WasiCoreCLRRelinkCoreRun opt-out and the
  _WasiCopyPrebuiltCoreRun fallback (there is no prebuilt corerun executable in
  the wasi CoreCLR runtime pack), and update comments to describe linking the
  shipping wasihost archive.
- Refresh corerun/relink wording in the WASI app-builder and test/CI wiring
  comments to reflect the wasihost host.

The per-app native link (ManagedToNativeGenerator -> compile callhelpers ->
link libWasiHost.a + runtime-pack static libs + app callhelper .o via
wasm-component-ld) is unchanged and matches the link dotnet#130816 validated.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f00a53c8-f7ba-4417-8ea6-30d0a1507a81
@lewing
lewing enabled auto-merge (squash) July 16, 2026 22:16
@build-analysis build-analysis Bot mentioned this pull request Jul 17, 2026
Open
3 tasks
This was referenced Jul 17, 2026
Closed
Closed
@lewing

lewing commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

/ba-g naot timeouts are constant

@lewing
lewing merged commit f079ec9 into dotnet:main Jul 17, 2026
167 of 177 checks passed
lewing added a commit to lewing/runtime that referenced this pull request Jul 17, 2026
@lewing
[wasi] Consume the shipping wasihost corehost (dotnet#130816) in the …
c3e9eb0 
…library-test leg

Adapt the CoreCLR-WASI library-test leg to build off the wasihost corehost
PR (dotnet#130816). Both PRs produced libWasiHost.a in the runtime pack native dir;
dotnet#130816 supplies it from a proper, statically-linked corehost
(src/native/corehost/wasihost), so this leg no longer needs to manufacture its
own host from corerun.

- corerun/CMakeLists.txt: drop the WasiHost-Static target (libWasiHost.a now
  comes from the wasihost corehost).
- corerun.cpp: revert the wasi ICU preload + weak GlobalizationNative_LoadICUData
  decl; wasihost.cpp loads icudt.dat from CORE_ROOT.
- Directory.Build.props: drop the duplicate libWasiHost.a platform-manifest entry
  (dotnet#130816 adds it in the wasi-specific section).
- WasiApp.CoreCLR.targets: the per-app link already links the pack's
  libWasiHost.a; remove the dead WasiCoreCLRRelinkCoreRun opt-out and the
  _WasiCopyPrebuiltCoreRun fallback (there is no prebuilt corerun executable in
  the wasi CoreCLR runtime pack), and update comments to describe linking the
  shipping wasihost archive.
- Refresh corerun/relink wording in the WASI app-builder and test/CI wiring
  comments to reflect the wasihost host.

The per-app native link (ManagedToNativeGenerator -> compile callhelpers ->
link libWasiHost.a + runtime-pack static libs + app callhelper .o via
wasm-component-ld) is unchanged and matches the link dotnet#130816 validated.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f00a53c8-f7ba-4417-8ea6-30d0a1507a81
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Jul 18, 2026
Merged
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 18, 2026
lewing added a commit that referenced this pull request Jul 21, 2026
@lewing
[wasi] Stand up CoreCLR-WASI library-test leg (per-app corerun relink) (
623e189 
#130745)

Draft. Stands up a CoreCLR-WASI library-test leg (smoke scope:
`System.Runtime.Tests`), addressing part of #130129.

Builds on the CoreCLR-WASI `wasihost` corehost (#130816, merged), which
ships `libWasiHost.a` in the runtime pack. This PR generates each test's
own reverse P/Invoke thunks and links them into that host per-app.

## What this does

Adds a per-app native link of the shipping `wasihost` corehost
(`libWasiHost.a`) so a test's own `[UnmanagedCallersOnly]` reverse
P/Invoke thunks are covered — mirroring the browser-CoreCLR relink. The
baked callhelpers table (`libcoreclr_gen_static.a`) only covers
framework top-level UCO callbacks; library/test callbacks (e.g. a nested
`WindowsUILanguageHelper.EnumUiLanguagesCallback`) are unknown to it and
trap at first use without the per-app link.

- **Host**: consumes `libWasiHost.a` from the `wasihost` corehost
(#130816) — the leg does not manufacture its own host.
- **Per-app link** (`src/mono/wasi/build/WasiApp.CoreCLR.targets`):
`ManagedToNativeGenerator` (TargetOS=wasi) → compile the generated
callhelpers with the wasi-sdk clang → link `libWasiHost.a` from the
runtime-pack static archives + the app callhelper `.o` (replacing
`libcoreclr_gen_static.a`) via `wasm-component-ld`. The `wasi:http`
import that `System.Net.*` pulls in is declared with
`-Wl,--component-type` (`WasiHttpWorld_component_type.wit`, as Mono
does); wasmtime is given `-S http` by the test targets.
- **Generator** (`ManagedToNativeGenerator.cs` /
`PInvokeTableGenerator.cs`): a `WarnOnUnresolvedPInvokeModules` flag
downgrades `WASM0066` to a message for untrimmed library-test closures
(whose foreign-platform P/Invokes are unresolved on wasm and never
called), so they don't fail the build under warn-as-error.
- **Test/CI wiring**: `tests.wasi.targets`, `sendtohelix-wasi.targets`,
`tests.proj` smoke set, and a `wasi-wasm-coreclr-library-tests` CI
template (non-gating, rolling).

The leg runs with full ICU globalization (non-invariant): the `wasihost`
corehost preloads `icudt.dat` from `CORE_ROOT`.

## Validation

Locally (macOS arm64, wasi-sdk + wasmtime): the baseline
(`clr+libs+host+packs -os wasi -c Release`) builds green and stages
`libWasiHost.a` from the `wasihost` corehost into the runtime pack. The
`System.Runtime.Tests` bundle links the host per-app and discovers +
runs the full suite:

```
Discovered: managed/System.Runtime.Tests.dll (found 9966 of 9966 test cases)
Starting:   managed/System.Runtime.Tests.dll
```

Managed exception dispatch through the interpreter EH + reverse UCO
thunks works with no precode assert. A `System.Tests.VersionTests`
subset ran 251/251 passing (`WASM EXIT 0`).

## Relationship to other work

- **#130816** (merged) — the `wasihost` corehost this leg links.
- **#130740** (merged) — the nested-UCO thunk-key generator fix the
interpreter needs to resolve nested reverse thunks.
- **#130634** stays scoped to the R2R `call_indirect` path (not this
pure-interpreter leg).

## Tracked follow-ups (not in this PR)

- **#130742** — build-switchable `wasi:http` capability (no-http vs
http-capable host), and the longer-term "statify the app-declared
imports" direction.
- **#130739** — token-based reverse-thunk key robustness.
- **#128362** — relocate `coreclr_compat.h` to a neutral shared location
+ stage the vm/minipal headers and the wit for out-of-tree/Helix runs
(the per-app link currently uses in-repo fallbacks in-tree).
- Polish: `-Wl,-u,__main_void` in place of `--whole-archive`, and
incremental `Inputs`/`Outputs` on the link target.

> [!NOTE]
> This pull request was authored with GitHub Copilot.

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelsavara pavelsavara pavelsavara left review comments
Copilot code review Copilot Copilot left review comments
@akoeplinger akoeplinger akoeplinger approved these changes
@radekdoulik radekdoulik Awaiting requested review from radekdoulik

Assignees

@lewing lewing

Labels

arch-wasm WebAssembly architecture area-Host os-wasi Related to WASI variant of arch-wasm

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@lewing @pavelsavara @akoeplinger