Add missing helix-platforms variables to superpmi-collect#130874
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 4 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
PTAL @dotnet/jit-contrib |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR SuperPMI collection pipelines to import the shared Helix platform alias variables, ensuring Helix queue variables (e.g., macOS ARM64 internal aliases) are available when the pipeline templates expand Helix queue names.
Changes:
- Include
/eng/pipelines/helix-platforms.ymlinsuperpmi-collect.ymlvariables. - Include
/eng/pipelines/helix-platforms.ymlinsuperpmi-collect-test.ymlvariables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/coreclr/superpmi-collect.yml | Adds the helix-platforms variables template so Helix queue aliases are defined for the production SuperPMI collection pipeline. |
| eng/pipelines/coreclr/superpmi-collect-test.yml | Adds the helix-platforms variables template so Helix queue aliases are defined for the test SuperPMI collection pipeline. |
Member
Author
|
@dotnet/jit-contrib Can I get a review? Trivial change |
JulieLeeMSFT
approved these changes
Jul 17, 2026
JulieLeeMSFT
left a comment
JulieLeeMSFT
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for fixing this long-standing issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes
seen internally in superpmi-collect.