Skip to content

[wasm] Html Encode incoming parameters to debug page #130960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraf merged 4 commits into from
Jul 19, 2026
Merged

[wasm] Html Encode incoming parameters to debug page #130960

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
294176c
HTML encode target URL
maraf Jun 9, 2026
5f9614f
Merge branch 'main' into maraf/WasmBugTargetUrl
maraf Jul 17, 2026
196bcf8
Merge branch 'main' into maraf/WasmBugTargetUrl
maraf Jul 17, 2026
07b5134
Merge branch 'main' into maraf/WasmBugTargetUrl
maraf Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/mono/wasm/host/DevServer/WebAssemblyNetDebugProxyAppBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,9 @@ public async Task Display(HttpContext context)
var debuggerTabsListUrl = $"{_browserHost}/json";
IEnumerable<BrowserTab> availableTabs;

var targetApplicationUrlEncoded = WebUtility.HtmlEncode(targetApplicationUrl.ToString());
var debuggerTabsListUrlEncoded = WebUtility.HtmlEncode(debuggerTabsListUrl);
Comment thread
maraf marked this conversation as resolved.

try
{
availableTabs = await GetOpenedBrowserTabs();
Expand All @@ -342,17 +345,17 @@ public async Task Display(HttpContext context)
await context.Response.WriteAsync($@"
<h1>Unable to find debuggable browser tab</h1>
<p>
Could not get a list of browser tabs from <code>{debuggerTabsListUrl}</code>.
Could not get a list of browser tabs from <code>{debuggerTabsListUrlEncoded}</code>.
Ensure your browser is running with debugging enabled.
</p>
<h2>Resolution</h2>
<p>
<h4>If you are using Google Chrome or Chromium for your development, follow these instructions:</h4>
{GetLaunchChromeInstructions(targetApplicationUrl.ToString())}
{GetLaunchChromeInstructions(targetApplicationUrlEncoded)}
</p>
<p>
<h4>If you are using Microsoft Edge (80+) for your development, follow these instructions:</h4>
{GetLaunchEdgeInstructions(targetApplicationUrl.ToString())}
{GetLaunchEdgeInstructions(targetApplicationUrlEncoded)}
Comment thread
lewing marked this conversation as resolved.
</p>
<strong>This should launch a new browser window with debugging enabled..</p>
Comment thread
lewing marked this conversation as resolved.
<h2>Underlying exception:</h2>
Expand All @@ -378,8 +381,8 @@ Ensure your browser is running with debugging enabled.

var suffix = string.IsNullOrEmpty(targetApplicationUrl)
? string.Empty
: $" matching the URL {WebUtility.HtmlEncode(targetApplicationUrl)}";
await context.Response.WriteAsync($"<p>The list of targets returned by {WebUtility.HtmlEncode(debuggerTabsListUrl)} contains no entries{suffix}.</p>");
: $" matching the URL {targetApplicationUrlEncoded}";
await context.Response.WriteAsync($"<p>The list of targets returned by {debuggerTabsListUrlEncoded} contains no entries{suffix}.</p>");
await context.Response.WriteAsync("<p>Make sure your browser is displaying the target application.</p>");
}
else
Expand Down
Loading