Skip to content

Update outerloop convert tests for saturating float/double casts #130974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Jul 17, 2026
Merged

Update outerloop convert tests for saturating float/double casts #130974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tests/JIT/IL_Conformance/Convert/TestConvertFromIntegral.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ static void TestConvertFromFloatToI2()
GenerateTest<float, short>(-1F, sourceOp, convNoOvf, DontExpectException, -1);
GenerateTest<float, short>(short.MaxValue, sourceOp, convNoOvf, DontExpectException, short.MaxValue);
GenerateTest<float, short>(short.MinValue, sourceOp, convNoOvf, DontExpectException, short.MinValue);
GenerateTest<float, short>(ushort.MaxValue, sourceOp, convNoOvf, DontExpectException, -1);
GenerateTest<float, short>(ushort.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour); // Saturates to short.MaxValue on CoreCLR, truncates on Mono (https://github.com/dotnet/runtime/issues/100368)
GenerateTest<float, short>(ushort.MinValue, sourceOp, convNoOvf, DontExpectException, byte.MinValue);
GenerateTest<float, short>(long.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<float, short>(long.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
Expand Down Expand Up @@ -977,7 +977,7 @@ static void TestConvertFromDoubleToI2()
GenerateTest<double, short>(-1, sourceOp, convNoOvf, DontExpectException, -1);
GenerateTest<double, short>(short.MaxValue, sourceOp, convNoOvf, DontExpectException, short.MaxValue);
GenerateTest<double, short>(short.MinValue, sourceOp, convNoOvf, DontExpectException, short.MinValue);
GenerateTest<double, short>(ushort.MaxValue, sourceOp, convNoOvf, DontExpectException, -1);
GenerateTest<double, short>(ushort.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour); // Saturates to short.MaxValue on CoreCLR, truncates on Mono (https://github.com/dotnet/runtime/issues/100368)
GenerateTest<double, short>(ushort.MinValue, sourceOp, convNoOvf, DontExpectException, byte.MinValue);
GenerateTest<double, short>(long.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, short>(long.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
Expand Down
2 changes: 1 addition & 1 deletion src/tests/JIT/Regression/CLR-x86-JIT/V1-M10/b05617/b05617.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ stloc.0
sub
sub
or
ldc.i8 4294967086
ldc.i8 4294967043
conv.u4
sub

Expand Down
2 changes: 2 additions & 0 deletions src/tests/JIT/Regression/CLR-x86-JIT/V1-M10/b05617/b05617.ilproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk.IL">
<PropertyGroup>
<CLRTestPriority>1</CLRTestPriority>
<!-- Saturating float->small casts on CoreCLR; Mono still truncates (https://github.com/dotnet/runtime/issues/100368) -->
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' == 'mono'">true</CLRTestTargetUnsupported>
</PropertyGroup>
<PropertyGroup>
<DebugType>PdbOnly</DebugType>
Expand Down
Loading