Skip to content

Add wasm HardwareIntrinsics PR pipeline#130975

Merged
tannergooding merged 1 commit into
dotnet:mainfrom
tannergooding:tannergooding-ci-intrinsics-wasm-filter
Jul 17, 2026
Merged

Add wasm HardwareIntrinsics PR pipeline#130975
tannergooding merged 1 commit into
dotnet:mainfrom
tannergooding:tannergooding-ci-intrinsics-wasm-filter

Conversation

@tannergooding

Copy link
Copy Markdown
Member

The wasm HardwareIntrinsics tests (src/tests/JIT/HardwareIntrinsics/Wasm) are gated by HWITestsWasmOnly -> CLRTestTargetUnsupported unless TargetArchitecture == wasm (plus an EnableWasmHWIntrinsicsTests opt-in). As a result, none of the existing PR-triggered intrinsics pipelines ever compile them:

  • runtime-coreclr hardware-intrinsics (src/coreclr/jit/**, x86/x64/arm/osx) passes without building the wasm tree.
  • hardware-intrinsics-arm64 (src/coreclr/jit/*arm64*) is skipped for wasm-only changes.

So a break in the wasm intrinsic tests only surfaces in a rolling/outerloop browser-wasm build, which is what required the #130962 follow-up to #130850.


This adds a wasm counterpart mirroring hardware-intrinsics-arm64.yml:

  • eng/pipelines/coreclr/hardware-intrinsics-wasm.yml -- PR-triggered, filtered on src/coreclr/jit/*wasm* (covers hwintrinsic*wasm*, lowerwasm.cpp, regallocwasm.cpp) plus src/tests/JIT/HardwareIntrinsics/Wasm/**. Runs a browser_wasm leg with /p:EnableWasmHWIntrinsicsTests=true -tree:JIT/HardwareIntrinsics/Wasm.
  • eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml -- modeled on the existing wasi-wasm-coreclr-runtime-tests.yml (global-build-job, runtimeFlavor: coreclr, -s clr+libs+packs). It is build-only (sendToHelix: false) since browser/V8 can''t execute these tests yet -- enough to catch compile breaks like Fix build break in PackedSimdTests in outerloop #130962.

Like hardware-intrinsics-arm64.yml, the new pipeline still needs an Azure DevOps definition registered against the YAML to appear as a PR check.

Note

This PR description was drafted by Copilot.

The wasm HardwareIntrinsics tests only compile when TargetArchitecture is
wasm, so no PR-triggered intrinsics pipeline exercised them -- letting build
breaks like dotnet#130962 slip through. Mirror hardware-intrinsics-arm64.yml with a
browser_wasm leg filtered on src/coreclr/jit/*wasm*, building the tests for
coverage only (browser/V8 can't run them yet).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new PR-triggered Azure Pipelines definition to ensure the wasm-specific HardwareIntrinsics test subtree (src/tests/JIT/HardwareIntrinsics/Wasm) is compiled on relevant PRs, preventing wasm-only intrinsic test compile breaks from slipping until outerloop/rolling wasm builds.

Changes:

  • Introduces a new hardware-intrinsics-wasm PR pipeline with path filters targeting wasm JIT files and wasm HardwareIntrinsics tests.
  • Adds a new CoreCLR build-only template job that builds clr+libs+packs and compiles the wasm HardwareIntrinsics test tree with EnableWasmHWIntrinsicsTests=true while explicitly skipping Helix execution (sendToHelix: false).
Show a summary per file
File Description
eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml Adds a browser-wasm CoreCLR build job that compiles the wasm HardwareIntrinsics tests (build-only, no Helix execution).
eng/pipelines/coreclr/hardware-intrinsics-wasm.yml Adds a PR-triggered pipeline with path filters and a browser_wasm leg wired to the new template.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@tannergooding
tannergooding marked this pull request as ready for review July 17, 2026 17:20
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@tannergooding

Copy link
Copy Markdown
Member Author

CC. @dhartglassMSFT (as you did the same work for -arm64), @dotnet/wasm-contrib

Working to get the AzDo pipeline too, this just ensures we aren't breaking the build (like the error that slipped through) and is the same we do for arm64/xarch

@adamperlin adamperlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me especially since this is build only, but I'll let someone more familiar with CI sign off.

@tannergooding

Copy link
Copy Markdown
Member Author

@akoeplinger for sign-off. This should unblock getting the azdo side finished

@tannergooding
tannergooding merged commit 7b037f1 into dotnet:main Jul 17, 2026
88 checks passed
@tannergooding
tannergooding deleted the tannergooding-ci-intrinsics-wasm-filter branch July 17, 2026 22:14
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants