Skip to content

Remove unused parse_only_production parameter from fx_ver parse#131101

Merged
elinor-fung merged 1 commit into
mainfrom
copilot/investigate-parse-only-production-parameter
Jul 21, 2026
Merged

Remove unused parse_only_production parameter from fx_ver parse#131101
elinor-fung merged 1 commit into
mainfrom
copilot/investigate-parse-only-production-parameter

Conversation

Copilot AI commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The parse_only_production parameter on c_fx_ver_parse / fx_ver_t::parse was never passed as true — every caller used false or the default of false.

cc @dotnet/appmodel @AaronRobinsonMSFT

Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@elinor-fung
elinor-fung marked this pull request as ready for review July 21, 2026 17:32
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@elinor-fung
elinor-fung merged commit 760860b into main Jul 21, 2026
174 checks passed
@elinor-fung
elinor-fung deleted the copilot/investigate-parse-only-production-parameter branch July 21, 2026 22:44
@github-project-automation github-project-automation Bot moved this to Done in AppModel Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants