Fix 130437 testcase for gcstress - #131171
Merged
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
dhartglassMSFT
commented
Jul 21, 2026
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the JIT regression IL test GitHub_130437 to use pinned managed byrefs (T& pinned) instead of pinned unmanaged pointers (T* pinned) and adjusts the call sites to convert the byref to an unmanaged pointer when invoking the SVE2 gather intrinsic. This keeps the array storage correctly pinned under GC stress while still satisfying the intrinsic’s uint32* parameter type.
Changes:
- Change locals from
uint32* pinned/int64* pinnedtouint32& pinned/int64& pinnedto ensure pinning is honored by the GC. - Add
conv.uat the intrinsic call sites to convert the pinned byref (uint32&) to an unmanaged pointer (uint32*) argument.
dhartglassMSFT
added
the
Priority:1
Member
|
/azp run runtime-coreclr crossgen2-composite gcstress, runtime-coreclr gcstress-extra |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Open
3 tasks
dhartglassMSFT
enabled auto-merge (squash)
July 23, 2026 06:44
Contributor
Author
|
ARM64 gcstress legs passed |
Contributor
Author
|
/ba-g known failures and timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testcase didn't pin pointers correctly for gcstress.
Using
int32* pinned blahdoesn't actually pin the local, we getIgnoring pin for non-GC type V05.Changing to pinned byrefs should fix the gcstress failure.
fixes #130993