Merge Runtime_131137 into the shared regression runner - #131173
Merged
tannergooding merged 1 commit intoJul 22, 2026
Merged
Conversation
The test sets no process-wide state and meets none of the isolation rules, so the standalone csproj was unnecessary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the Runtime_131137 JIT regression test into the shared Regression_ro_2 merged test runner, eliminating the standalone project that previously built and ran the test in isolation.
Changes:
- Add
JitBlue\Runtime_131137\Runtime_131137.cstoRegression_ro_2.csprojso it is built as part of the merged regression runner. - Remove the standalone
Runtime_131137.csproj(previously markedRequiresProcessIsolation=true).
Show a summary per file
| File | Description |
|---|---|
| src/tests/JIT/Regression/Regression_ro_2.csproj | Adds Runtime_131137.cs to the merged regression runner compilation list. |
| src/tests/JIT/Regression/JitBlue/Runtime_131137/Runtime_131137.csproj | Removes the now-unneeded standalone test project. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
tannergooding
enabled auto-merge (squash)
July 21, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #131155 (comment).
Runtime_131137was added with a standalone.csprojandRequiresProcessIsolation=true, but the test meets none of the isolation rules inrequiresprocessisolation.md-- it sets no environment variables, no host config, and no process-wide state. It''s just a[ConditionalFact]in aRuntime_131137namespace with no customMain, so it merges cleanly.This removes the standalone project and adds the source into the shared
Regression_ro_2.csprojrunner, matching the rest of the regression tests.I also audited the other recently-added
JitBluetests that still carry standalone csprojs. All of them are justified: the immediate neighborsRuntime_130844/130845/130846setCLRTestEnvironmentVariable, the remaining ISO ones setCLRTestEnvironmentVariable/CLRTestTargetUnsupported, andRuntime_8980disables the xunit wrapper generator.Runtime_131137was the only one with no trigger.CC. @EgorBo
Note
This PR description was drafted by Copilot.