Skip to content

Enable R2R for unresolved static virtual interface calls #131282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 2 commits into from
Jul 29, 2026
+3 −4
Merged

Enable R2R for unresolved static virtual interface calls #131282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f16965a
Enable R2R runtime lookup for unresolved static virtual calls
jkoritzinsky Jul 23, 2026
8af4931
Merge branch 'main' into fix/r2r-unresolved-static-virtual-lookup
jkoritzinsky Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2324,16 +2324,15 @@ private void ceeInfoGetCallInfo(
{
if (pResult->exactContextNeedsRuntimeLookup)
{
throw new RequiresRuntimeJitException("EmbedGenericHandle currently doesn't support propagation of RUNTIME_LOOKUP or pConstrainedResolvedToken from ComputeRuntimeLookupForSharedGenericToken");
// ComputeRuntimeLookupForSharedGenericToken(DictionaryEntryKind.DispatchStubAddrSlot, ref pResolvedToken, pConstrainedResolvedToken, originalMethod, ref pResult->codePointerOrStubLookup);
// useInstantiatingStub = false;
pResult->kind = CORINFO_CALL_KIND.CORINFO_CALL_CODE_POINTER;
ComputeRuntimeLookupForSharedGenericToken(DictionaryEntryKind.ConstrainedMethodEntrySlot, ref pResolvedToken, pConstrainedResolvedToken, originalMethod, HandleToObject(callerHandle), ref pResult->codePointerOrStubLookup);
useInstantiatingStub = true;
Comment thread
jkoritzinsky marked this conversation as resolved.
}
else
{
throw new RequiresRuntimeJitException("CanInline currently doesn't support propagation of constrained type so that we cannot reliably tell whether a SVM call can be inlined");
// Even if we decided to support SVMs unresolved at compile time, we'd still need to force the use of instantiating stub
// as we can't tell in advance whether the method will be runtime-resolved to a canonical representation.
// useInstantiatingStub = true;
}
}
}
Expand Down
Loading