Skip to content

Use IL shuffle thunk on all platforms #131303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huoyaoyuan wants to merge 2 commits into from
Closed

Use IL shuffle thunk on all platforms #131303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e4bd0
Enable benchmark
huoyaoyuan Jul 24, 2026
1e269bf
Apply IL pattern optimization
huoyaoyuan Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/coreclr/vm/comdelegate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,11 +846,16 @@ static Stub* CreateILDelegateShuffleThunk(MethodDesc* pDelegateMD, bool callTarg
ILStubLinker stubLinker(pModule, signature, &typeContext, pDelegateMD, flags);
ILCodeStream *pCode = stubLinker.NewCodeStream(ILStubLinker::kDispatch);

// Store the function pointer into local variable to avoid unnecessary register usage by JIT
DWORD methodPtr = pCode->NewLocal(ELEMENT_TYPE_I);
pCode->EmitLoadThis();
pCode->EmitLDFLD(pCode->GetToken(CoreLibBinder::GetField(FIELD__DELEGATE__METHOD_PTR_AUX)));
pCode->EmitSTLOC(methodPtr);

for (unsigned i = 0; i < sig.NumFixedArgs(); ++i)
pCode->EmitLDARG(i);

pCode->EmitLoadThis();
pCode->EmitLDFLD(pCode->GetToken(CoreLibBinder::GetField(FIELD__DELEGATE__METHOD_PTR_AUX)));
pCode->EmitLDLOC(methodPtr);
pCode->EmitCALLI(TOKEN_ILSTUB_TARGET_SIG, sig.NumFixedArgs(), sig.IsReturnTypeVoid() ? 0 : 1);
pCode->EmitRET();

Expand Down Expand Up @@ -910,7 +915,7 @@ static PCODE SetupShuffleThunk(MethodTable * pDelMT, MethodDesc *pTargetMeth)

MethodDesc *pMD = pClass->GetInvokeMethod();

#if defined(FEATURE_PORTABLE_SHUFFLE_THUNKS) || defined(TARGET_X86)
#if 0
// We haven't already setup a shuffle thunk, go do it now (which will cache the result automatically).
StackSArray<ShuffleEntry> rShuffleEntryArray;
if (GenerateShuffleArray(pMD, pTargetMeth, &rShuffleEntryArray))
Expand Down
Loading