Support CIDR notation in NO_PROXY env variable - #131397
Merged
Merged
Conversation
CIDR notation like 127.0.0.0/8 in the `NO_PROXY`/`no_proxy` environment variables is currently not handled. These entries will be silently ignored because only exact entries like 127.0.0.1 can cause `HttpEnvironmentProxy.IsBypassed` to return `true`. Address this by introducing support for IPv4 and IPv6 CIDR notation into `HttpEnvironmentProxy`. The CIDR parsing is done at construction-time to minimize the time spent parsing on each individual HTTP request. Additionally, CIDR-based matching will not be performed unless at least one CIDR block is actually present in `NO_PROXY`. Fix dotnet#131293
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
MihaZupan
approved these changes
Jul 26, 2026
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Contributor
Author
|
I don't think that build failure is caused by my changes. I'm new to this repo, so I'm not sure what the process is, but let me know if I need to rebase or merge main. |
Member
|
No need to do anything on your part, the PR just needs a secondary review since I also made changes. Some tests aren't always stable, so this repo uses "Build Analysis" (you can see it under the passing checks) to detect when unknown failures occurred that should block the PR from being merged. |
ManickaP
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIDR notation like 127.0.0.0/8 in the
NO_PROXY/no_proxyenvironment variables is currently not handled. These entries will be silently ignored because only exact entries like 127.0.0.1 can causeHttpEnvironmentProxy.IsBypassedto returntrue.Address this by introducing support for IPv4 and IPv6 CIDR notation into
HttpEnvironmentProxy. The CIDR parsing is done at construction-time to minimize the time spent parsing on each individual HTTP request. Additionally, CIDR-based matching will not be performed unless at least one CIDR block is actually present inNO_PROXY.Fix #131293