-
Notifications
You must be signed in to change notification settings - Fork 5.5k
JIT: include element info when comparing array address trees #131485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+188
−6
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149 changes: 149 additions & 0 deletions
149
src/tests/JIT/Regression/JitBlue/Runtime_131459/Runtime_131459.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Runtime_131459; | ||
|
|
||
| using System; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.InteropServices; | ||
| using Xunit; | ||
|
|
||
| [StructLayout(LayoutKind.Sequential, Size = 16)] | ||
| internal struct S16 | ||
| { | ||
| public byte Value; | ||
| } | ||
|
|
||
| [StructLayout(LayoutKind.Sequential, Size = 252)] | ||
| internal struct S252 | ||
| { | ||
| public byte Value; | ||
| } | ||
|
|
||
| [StructLayout(LayoutKind.Sequential, Size = 256)] | ||
| internal struct S256 | ||
| { | ||
| public byte Value; | ||
| } | ||
|
|
||
| [StructLayout(LayoutKind.Sequential, Size = 512)] | ||
| internal struct S512 | ||
| { | ||
| public byte Value; | ||
| } | ||
|
|
||
| public class Runtime_131459 | ||
| { | ||
| [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] | ||
| private static ref byte Address(bool small, object array) | ||
| { | ||
| if (small) | ||
| { | ||
| ref S16 element = ref Unsafe.As<S16[,]>(array)[0, 1]; | ||
| return ref Unsafe.As<S16, byte>(ref element); | ||
| } | ||
| else | ||
| { | ||
| ref S252 element = ref Unsafe.As<S252[,]>(array)[0, 1]; | ||
| return ref Unsafe.As<S252, byte>(ref element); | ||
| } | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] | ||
| private static ref byte AddressBig(bool small, object array) | ||
| { | ||
| if (small) | ||
| { | ||
| ref S256 element = ref Unsafe.As<S256[,]>(array)[0, 1]; | ||
| return ref Unsafe.As<S256, byte>(ref element); | ||
| } | ||
| else | ||
| { | ||
| ref S512 element = ref Unsafe.As<S512[,]>(array)[0, 1]; | ||
| return ref Unsafe.As<S512, byte>(ref element); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| [Fact] | ||
| public static void TestEntryPoint() | ||
| { | ||
| S16[,] small = new S16[1, 2]; | ||
| small[0, 1].Value = 16; | ||
|
|
||
| S252[,] large = new S252[1, 2]; | ||
| large[0, 1].Value = 252; | ||
|
|
||
| Assert.Equal(16, Address(true, small)); | ||
| Assert.Equal(252, Address(false, large)); | ||
|
|
||
| S256[,] smallBig = new S256[1, 2]; | ||
| smallBig[0, 1].Value = 16; | ||
|
|
||
| S512[,] largeBig = new S512[1, 2]; | ||
| largeBig[0, 1].Value = 252; | ||
|
|
||
| Assert.Equal(16, AddressBig(true, smallBig)); | ||
| Assert.Equal(252, AddressBig(false, largeBig)); | ||
| } | ||
|
|
||
| // GT_ARR_ADDR carries the array element type and class handle. If GenTree::Compare ignores | ||
| // them, tail merge folds the two arms below into one and the surviving node claims long[], | ||
| // which lets value numbering treat the store through 'r' as not aliasing da[1]. | ||
| [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] | ||
| private static double ArrayElementTypeMerge(bool useLongArray, double[] da, object array) | ||
| { | ||
| ref byte r = ref Unsafe.NullRef<byte>(); | ||
| if (useLongArray) | ||
| { | ||
| r = ref Unsafe.As<long, byte>(ref Unsafe.As<long[]>(array)[1]); | ||
| } | ||
| else | ||
| { | ||
| r = ref Unsafe.As<double, byte>(ref Unsafe.As<double[]>(array)[1]); | ||
| } | ||
|
|
||
| double before = da[1]; | ||
| Unsafe.WriteUnaligned<long>(ref r, 0x4045000000000000L); | ||
| return da[1] - before; | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void ArrayElementType() | ||
| { | ||
| double[] da = new double[2]; | ||
| Assert.Equal(42.0, ArrayElementTypeMerge(false, da, da)); | ||
| } | ||
|
|
||
| // GT_INDEX_ADDR also carries the "needs a range check" and "known non-null" bits. | ||
| // MemoryMarshal.GetArrayDataReference expands to an IndexAddr with the range check | ||
| // cleared, so if GenTree::Compare ignores those bits, tail merge can fold the two arms | ||
| // below and drop the range check on the a[0] path. The two trees only line up when the | ||
| // index constants have the same type, which is the case on 32-bit targets. | ||
| [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] | ||
| private static int BoundsCheckMerge(bool useDataReference, S16[] array) | ||
| { | ||
| S16 element; | ||
| if (useDataReference) | ||
| { | ||
| element = MemoryMarshal.GetArrayDataReference(array); | ||
| } | ||
| else | ||
| { | ||
| element = array[0]; | ||
| } | ||
|
|
||
| return element.Value + 1; | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void BoundsCheck() | ||
| { | ||
| S16[] nonEmpty = new S16[2]; | ||
| Assert.Equal(1, BoundsCheckMerge(true, nonEmpty)); | ||
| Assert.Equal(1, BoundsCheckMerge(false, nonEmpty)); | ||
|
|
||
| S16[] empty = new S16[0]; | ||
| Assert.Throws<IndexOutOfRangeException>(() => BoundsCheckMerge(false, empty)); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.