[s390x] add in-process crash reporter for s390x - #131796
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
uweigand
reviewed
Aug 4, 2026
uweigand
left a comment
Contributor
There was a problem hiding this comment.
Looks good except for the frame pointer register.
saitama951
force-pushed
the
inproc_crash_fix
branch
from
August 4, 2026 13:19
028ae47 to
e72b7de
Compare
saitama951
marked this pull request as ready for review
August 4, 2026 13:20
Contributor
Author
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
am11
approved these changes
Aug 4, 2026
am11
left a comment
Member
There was a problem hiding this comment.
LGTM, lets add ppc64le as well while at it.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Contributor
Author
|
done |
Member
|
Note that we need changes from #131700 as well to make it actually recognize the HAVE_ macros. Those platforms produce different results than linux and others. |
jkotas
approved these changes
Aug 4, 2026
Member
|
/ba-g infrastructure timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131535 for linux-s390x, #131604 introduced a build error