Skip to content

[s390x] add in-process crash reporter for s390x - #131796

Merged
jkotas merged 2 commits into
dotnet:mainfrom
saitama951:inproc_crash_fix
Aug 5, 2026
Merged

[s390x] add in-process crash reporter for s390x#131796
jkotas merged 2 commits into
dotnet:mainfrom
saitama951:inproc_crash_fix

Conversation

@saitama951

@saitama951 saitama951 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #131535 for linux-s390x, #131604 introduced a build error

  /home/sanjam/runtime/src/coreclr/debug/crashreport/inproccrashreporter.cpp:62:2: error: "Unsupported arch"
     62 | #error "Unsupported arch"
        |  ^
  /home/sanjam/runtime/src/coreclr/debug/crashreport/inproccrashreporter.cpp:89:1: error: expected expression
     89 | struct StackOverflowTraceFrame
        | ^
  /home/sanjam/runtime/src/coreclr/debug/crashreport/inproccrashreporter.cpp:102:5: error: unknown type name 'StackOverflowTraceFrame'; did you mean 'StackOverflowTraceSnapshot'?
    102 |     StackOverflowTraceFrame frames[CRASHREPORT_STACK_OVERFLOW_MAX_TRACE_FRAMES];
        |     ^~~~~~~~~~~~~~~~~~~~~~~
        |     StackOverflowTraceSnapshot


....

  /home/sanjam/runtime/src/coreclr/debug/crashreport/inproccrashreporter.cpp:1245:6: error: "Unsupported arch"
   1245 |     #error "Unsupported arch"
        |      ^
  /home/sanjam/runtime/src/coreclr/debug/crashreport/inproccrashreporter.cpp:1258:12: error: use of undeclared identifier 'CRASH_MCREG_PC'
   1258 |     return CRASH_MCREG_PC(ucontext);
        |            ^
  /home/sanjam/runtime/src/coreclr/debug/crashreport/inproccrashreporter.cpp:1271:12: error: use of undeclared identifier 'CRASH_MCREG_SP'
   1271 |     return CRASH_MCREG_SP(ucontext);
        |            ^
  /home/sanjam/runtime/src/coreclr/debug/crashreport/inproccrashreporter.cpp:1284:12: error: use of undeclared identifier 'CRASH_MCREG_FP'
   1284 |     return CRASH_MCREG_FP(ucontext);

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 4, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@uweigand uweigand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the frame pointer register.

Comment thread src/coreclr/debug/crashreport/inproccrashreporter.cpp Outdated
@saitama951
saitama951 marked this pull request as ready for review August 4, 2026 13:20
@saitama951

Copy link
Copy Markdown
Contributor Author

cc: @am11 @jkotas

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@am11 am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets add ppc64le as well while at it.

Comment thread src/coreclr/debug/crashreport/inproccrashreporter.cpp
Comment thread src/coreclr/debug/crashreport/inproccrashreporter.cpp
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@saitama951

Copy link
Copy Markdown
Contributor Author

done

@am11

am11 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Note that we need changes from #131700 as well to make it actually recognize the HAVE_ macros. Those platforms produce different results than linux and others.

@jkotas

jkotas commented Aug 5, 2026

Copy link
Copy Markdown
Member

/ba-g infrastructure timeouts

@jkotas
jkotas merged commit 7ddca6e into dotnet:main Aug 5, 2026
109 of 118 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-ppc64le area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CoreCLR] Complete in-process crash reporter support for community platforms

4 participants