Enable HTTP/2 client cert authentication in WinHttpHandler - #33158
Merged
alnikola merged 26 commits intoMar 19, 2020
Merged
Conversation
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidsh
approved these changes
Mar 5, 2020
davidsh
left a comment
davidsh
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM.
But as we discussed offline, we need to have some kind of test coverage to run these tests with WinHttpHandler against .NET Framework. You can either make that part of this PR or a separate PR.
…uth for older Windows and net472
HTTP/2 tests enabled for .Net Core only
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
Author
|
/azp list |
Contributor
|
/azp run runtime-libraries outerloop |
|
Commenter does not have sufficient privileges for PR 33158 in repo dotnet/runtime |
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| sslStream.AuthenticateAsServerAsync(options, CancellationToken.None).Wait(); | ||
| #else | ||
| sslStream.AuthenticateAsServerAsync(cert, httpOptions.ClientCertificateRequired, httpOptions.SslProtocols, checkCertificateRevocation: false).Wait(); |
Contributor
There was a problem hiding this comment.
Does WinHTTP ignore ALPN?
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-release WinHTTP's version supports client cert authentication over HTTP/2, but the feature must be explicitly opted-in. PR sets WINHTTP_OPTION_ENABLE_HTTP2_PLUS_CLIENT_CERT to TRUE before invoking WinHttpConnect if the request's protocol is HTTP/2 and scheme is HTTPS.