Disable Bitmap round-tripping tests for old libgdiplus versions - #34354
Merged
Conversation
Old libgdiplus versions have uninitialized stack variable bug that makes Bitmap round-tripping unreliable. The bug causes Bitmap.Flags, Bitmap.HorizontalResolution and Bitmap.VerticalResolution properties to be set to bogus values if the stack happens to contain certain bit patterns. This bug was fixed for libgdiplus 6 by mono/libgdiplus@81e45a1#diff-c96a8261ecb168c12b44248208da21c0R118.
stephentoub
approved these changes
Apr 1, 2020
stephentoub
left a comment
stephentoub
left a comment
Member
There was a problem hiding this comment.
Nice job tracking it down.
safern
approved these changes
Apr 1, 2020
safern
left a comment
safern
left a comment
Member
There was a problem hiding this comment.
Good job tracking it down. I wonder why it hasn’t failed on Ubuntu16.04 as those machines also have an old libgdiplus.
I’ll work on updating libgdiplus with the engineering team on those machines.
Member
|
Failure is: #34358 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old libgdiplus versions have uninitialized stack variable bug that makes Bitmap round-tripping unreliable. The bug causes Bitmap.Flags, Bitmap.HorizontalResolution and Bitmap.VerticalResolution properties to be set to bogus values if the stack happens to contain certain bit patterns. This bug was fixed for libgdiplus 6 by mono/libgdiplus@81e45a1#diff-c96a8261ecb168c12b44248208da21c0R118.