[release/5.0-preview3] Fix System.Data.SqlClient baseline (#34352) - #34397
Merged
danmoseley merged 1 commit intoApr 1, 2020
Merged
Conversation
* Fix System.Data.SqlClient version Fixes dotnet#34351 * Update Microsoft.Windows.Compatibility.pkgproj
Contributor
|
Supportive. Is there a checklist we need to tweak to avoid this next time? |
Member
|
cc @jkotas |
Contributor
|
was approved |
danmoseley
added
Servicing-approved
Member
A checklist for deleting a library from the repo? Not sure we have such a thing or if it happens often enough. I do think we should test the compat pack during package testing. @safern can you file an issue for that? I suspect it's not being tested because it's not validated for support. |
Member
|
Nevermind, we have that issue: #27503 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the package baseline for Microsoft.Windows.Compatibility so that the System.Data.SqlClient dependency is 4.8.1
Customer Impact
In preview1 and 2, Microsoft.Windows.Compatibility is dependent on System.Data.SqlClient 5.0.0-preview.X. System.Data.SqlClient is currently at 4.8.1, so this makes the package unusable.
Regression?
Yes,
Risk
Low, fix in master has been verified.