Fix write behind allocated memory in thread name setting - #34424
Merged
janvorli merged 1 commit intoApr 2, 2020
Conversation
The code in CorUnix::InternalSetThreadDescription is writing behind the end of the allocated memory in case the name is shorter than 16 characters. That is causing memory heap corruption.
Member
Author
|
cc: @mmitche |
jkotas
approved these changes
Apr 1, 2020
Member
|
Thanks! I'll port this to preview3 once this fix is finalized |
mmitche
pushed a commit
to mmitche/runtime
that referenced
this pull request
Apr 2, 2020
The code in CorUnix::InternalSetThreadDescription is writing behind the end of the allocated memory in case the name is shorter than 16 characters. That is causing memory heap corruption.
mmitche
added a commit
that referenced
this pull request
Apr 2, 2020
…4437) The code in CorUnix::InternalSetThreadDescription is writing behind the end of the allocated memory in case the name is shorter than 16 characters. That is causing memory heap corruption. Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
This was referenced Apr 2, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in CorUnix::InternalSetThreadDescription is writing behind
the end of the allocated memory in case the name is shorter than 16
characters. That is causing memory heap corruption.
The problem was discovered in dotnet/installer#6876