Skip to content

Fix WriteLargeJsonToStreamWithoutFlushing test - #34489

Merged
stephentoub merged 1 commit into
dotnet:masterfrom
layomia:writer_test
Apr 3, 2020
Merged

Fix WriteLargeJsonToStreamWithoutFlushing test#34489
stephentoub merged 1 commit into
dotnet:masterfrom
layomia:writer_test

Conversation

@layomia

@layomia layomia commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

Fixes #34481.

This test wasn't updated following #32587, where the exception for this scenario changed from OverflowException to OutOfMemoryException.

@layomia

layomia commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

cc @danmosemsft

@stephentoub

Copy link
Copy Markdown
Member

Thanks.

@stephentoub
stephentoub merged commit 07187e3 into dotnet:master Apr 3, 2020
@danmoseley

Copy link
Copy Markdown
Contributor

How did it get through gated checkin, do you know @layomia?

@stephentoub

Copy link
Copy Markdown
Member

It's OuterLoop.

@danmoseley

Copy link
Copy Markdown
Contributor

Thanks. As soon as I commented I realized that.

layomia added a commit to layomia/dotnet_runtime that referenced this pull request Apr 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@layomia
layomia deleted the writer_test branch May 18, 2021 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WriteLargeJsonToStreamWithoutFlushing failing in libraries outer loop

4 participants