Skip to content

Resetting _waitForCompletion to null was removed from DuplexContent - #35010

Merged
alnikola merged 3 commits into
dotnet:masterfrom
alnikola:alnikola/33141-sendasync-concurent-send-receive-ok
Apr 17, 2020
Merged

Resetting _waitForCompletion to null was removed from DuplexContent#35010
alnikola merged 3 commits into
dotnet:masterfrom
alnikola:alnikola/33141-sendasync-concurent-send-receive-ok

Conversation

@alnikola

Copy link
Copy Markdown
Contributor

_waitForCompletion gets reset to null in DuplexContent.Complete and Fail which leads to race condition with SerializeToStreamAsync. This reset seems redundant since _waitForCompletion is always unconditionally initialized on each call to SerializeToStreamAsync. This PR removes that reset logic.

Fixes #33141

@ghost

ghost commented Apr 15, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@davidsh davidsh added this to the 5.0 milestone Apr 15, 2020
@alnikola

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@alnikola

Copy link
Copy Markdown
Contributor Author

/azp stop runtime

@azure-pipelines

Copy link
Copy Markdown
Command 'stop' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@alnikola

Copy link
Copy Markdown
Contributor Author

/azp help

@azure-pipelines

Copy link
Copy Markdown
Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@alnikola

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@alnikola
alnikola merged commit 9fd1e23 into dotnet:master Apr 17, 2020
@alnikola
alnikola deleted the alnikola/33141-sendasync-concurent-send-receive-ok branch April 17, 2020 11:52
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SendAsync_ConcurentSendReceive_Ok is failing in CI

4 participants