Http2LoopbackConnection properly handles stream termination - #35100
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
| EnableUncryptedHttp2(socketsHttpHandler); | ||
| } | ||
|
|
||
| #if !NETFRAMEWORK |
There was a problem hiding this comment.
Why do we need this? Should we fix either PlatformDetection or the capability Instead?
There was a problem hiding this comment.
SocketsHttpHandler type is not available on the full .Net Framework, so conditional compilation seems to be the only way.
There was a problem hiding this comment.
So why type it as SocketsHttpHandler rather than object, as the other functions this is called from and it's calling are doing?
There was a problem hiding this comment.
It's to distinct it from the other overload taking HttpClientHandler.
There was a problem hiding this comment.
Of course, I could have made it object, but think an explicit type is more convenient.
ghost
locked as resolved and limited conversation to collaborators
6 participants
PR adds an optional stream termination handling to
Http2LoopbackConnection.ReadBodyAsyncand fixesHttpClientconstruction missing theSocketHttpHandlercreated in the test.Fixes #31220