Build iOS AOT compiler against LLVM, always - #35306
Merged
Merged
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
akoeplinger
approved these changes
Apr 22, 2020
Member
Not strictly necessary since we pass the path to opt/llc explicitly to the --aot option. |
3 tasks
steveisok
self-requested a review
April 22, 2020 22:57
steveisok
approved these changes
Apr 22, 2020
Member
|
I think this is ok to take off of draft status. |
EgorBo
approved these changes
Apr 23, 2020
directhex
marked this pull request as ready for review
April 23, 2020 12:03
directhex
requested review from
SamMonoRT,
imhameed,
marek-safar and
vargaz
as code owners
April 23, 2020 12:03
Contributor
Author
|
I didn't expect all checks to pass 😅 |
Member
|
well let's get it in :) |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in line with our discussions about which platforms are JIT and which are AOT and which are LLVM AOT.
We can't just blithely use our MonoEnableLLVM logic, as we do not want the iOS JIT build with LLVM.
Probably need to double-check that the mono-aot-cross command is definitely consuming llc/opt from its own directory, not $PATH.