WIP: Revert "Add runtimeFlavor parameter to build-test-job.yml" - #35414
Closed
trylek wants to merge 1 commit into
Closed
WIP: Revert "Add runtimeFlavor parameter to build-test-job.yml"#35414trylek wants to merge 1 commit into
trylek wants to merge 1 commit into
Conversation
This reverts commit 5959364.
|
Tagging subscribers to this area: @ViktorHofer |
Member
Author
|
OK, so the good news for me is that this rollback change is still hitting the same issue in rolling build so I guess that means my change is not the culprit. That however doesn't change the fact that rolling builds are on the floor again. |
Member
Author
|
Thankfully not applicable - my change hasn't broken the rolling build after all and Santi has already merged the fix in: #35416 (comment) |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #35377
Sigh. For some reason, this seemingly unrelated change has broken the rolling build again. I'm not yet convinced we need to back the change out as I suspect the fix is going to be elsewhere and my change probably just uncovered it by properly propagating the runtime names but I'm triggering testing for the rollback nonetheless just to be sure.
Thanks
Tomas