Skip to content

Revert "Build an apphost with hostfxr and hostpolicy linked in (#35368)" - #36076

Merged
safern merged 1 commit into
dotnet:masterfrom
safern:RevertMuslBreak
May 8, 2020
Merged

Revert "Build an apphost with hostfxr and hostpolicy linked in (#35368)"#36076
safern merged 1 commit into
dotnet:masterfrom
safern:RevertMuslBreak

Conversation

@safern

@safern safern commented May 8, 2020

Copy link
Copy Markdown
Member

This reverts commit f6e5219.

This change broke Linux_musl_x64 Release rolling builds. We need to bring pass rate up and has been failing for 2 days without any fix. Usually we try to revert after 1 day.

Fixes: #35967

cc: @dotnet/runtime-infrastructure @VSadov @swaroop-sridhar

@ghost

ghost commented May 8, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar
Notify danmosemsft if you want to be subscribed.

@safern
safern force-pushed the RevertMuslBreak branch from 21cd4f3 to 6cc01d4 Compare May 8, 2020 00:28

@swaroop-sridhar swaroop-sridhar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be OK with this -- in order to keep the lab green.

However, @VSadov @safern it'd be good to actually verify that the release tests will pass if we revert this change. I'll start a run now -- unless one of you already checked it. Thanks.

@swaroop-sridhar

Copy link
Copy Markdown
Contributor

CC: @jeffschwMSFT

@swaroop-sridhar

Copy link
Copy Markdown
Contributor

For more details please see: #35755

@safern

safern commented May 8, 2020

Copy link
Copy Markdown
Member Author

I queued a rolling build from this branch here: https://dev.azure.com/dnceng/public/_build/results?buildId=635948&view=results

@VSadov

VSadov commented May 8, 2020

Copy link
Copy Markdown
Member

is it possible to run the musli thing on this PR with some azp command?

@VSadov

VSadov commented May 8, 2020

Copy link
Copy Markdown
Member

@safern - Thanks!

@safern

safern commented May 8, 2020

Copy link
Copy Markdown
Member Author

is it possible to run the musli thing on this PR with some azp command?

No, you have to queue it manually from the UI and then set the branch to: refs/pull/<pr-id>/merge

@safern

safern commented May 8, 2020

Copy link
Copy Markdown
Member Author

So the Installer leg in Linux_musl_x64 Release is green in my rolling build with this revert:
https://dev.azure.com/dnceng/public/_build/results?buildId=635948&view=logs&j=bf685d4e-b902-5b69-856e-ae456c52090c

@safern
safern merged commit 3011955 into dotnet:master May 8, 2020
@safern
safern deleted the RevertMuslBreak branch May 8, 2020 03:19
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer Build and Test coreclr Linux_musl_x64 Release failing in CI

4 participants