[Outdated] Implementation of CSE for GT_CNS_INT benefits ARM64. by briansull · Pull Request #36831 · dotnet/runtime

Mark Div/Mod nodes that will use reciprocal multiply with GTF_DIV_USE_MAGIC

briansull

committed

Update the LclVar ref counts for new CSE LclVars

briansull

committed

Change csdHashKey to INT64, change the CSE hash key to size_t

briansull

committed

Update usesMagicNumberDivision() to handle some additional cases

briansull

committed

Update the gtCost values for constant nodes: GT_CNS_INT, GT_CNS_LNG, GT_CNS_STR

briansull

committed

Fix usesMagicNumberDivision for unsigned divide of MIN_INT

briansull

committed

If a tree node has had SetRegNum() called to assign it to a physical register and that node becomes a CSE

briansull

committed

As part of the CSE of constants work, once we make a CSE we don't want constant prop to undo the CSE operation

briansull

committed

When we duplicate a conditional test to change a loop into a bottom tested loop

briansull

committed

In invariant hoisting the hoist Expr does not have to computed into a specific register,

briansull

committed

Change the weights of GT_CNS_INT for ARM64

briansull

committed

Don't auto retry when using the AltJit as that results in two copies of every method in the output file

briansull

committed

Implementation of CSE for GT_CNS_INT using a single CSE for constant values that differ only in the low 12 bits.

briansull

committed

Fix for JitDisableConstCSE() == 3

briansull

committed

In CSE added check for mismatched types on GT_CNS_INT nodes

briansull

committed

Fix assert divMod->markedMagicNumberDivision()

briansull

committed

Propagate the gtFlags for a gtCallAddr node

briansull

committed

Propagating a constant may create an opportunity to use a magic number division

briansull

committed

Only perform conversion of floating point GT_DIV to an exact reciprocal GT_MUL when fgGlobalMorph is true

briansull

committed

Mark the non-standard virtual stub indirection address arg with GTF_DONT_CSE

briansull

committed

Changes for config variable JitDisableConstCSE - remove values 4 and 5

briansull

committed

Allow CSE of the R2R indirect param constant address

briansull

committed

Fix Assertion failed 'isValidGeneralDatasize(size)'

briansull

committed

Change gtCostEx for 8-byte constants on AMD64 to be 2 so that they are CSE candidates

briansull

committed

Workaround for ARM32 assert when CSE of Consts is enabled

briansull

committed

Add a simple sort to compute the best shared const CSE's to use for the definition, sets csdConstDefValue and csdConstDefVN

briansull

committed

Fix the gtCost GT_CNS_LNG for ARM32

briansull

committed

Update arm32 GT_CNS costs.

briansull

committed

Fix in AssertionProp for JitStress issue with beq_r8 test

briansull

committed

Added additional Priority 0 test coverage for Floating Point optimizations

briansull

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Outdated] Implementation of CSE for GT_CNS_INT benefits ARM64. - #36831

[Outdated] Implementation of CSE for GT_CNS_INT benefits ARM64.#36831
briansull wants to merge 30 commits into
dotnet:masterfrom
briansull:cse-const-shared

Commits on Jul 8, 2020

Mark Div/Mod nodes that will use reciprocal multiply with GTF_DIV_USE_MAGIC

Update the LclVar ref counts for new CSE LclVars

Change csdHashKey to INT64, change the CSE hash key to size_t

Update usesMagicNumberDivision() to handle some additional cases

Update the gtCost values for constant nodes: GT_CNS_INT, GT_CNS_LNG, GT_CNS_STR

Fix usesMagicNumberDivision for unsigned divide of MIN_INT

If a tree node has had SetRegNum() called to assign it to a physical register and that node becomes a CSE

As part of the CSE of constants work, once we make a CSE we don't want constant prop to undo the CSE operation

When we duplicate a conditional test to change a loop into a bottom tested loop

In invariant hoisting the hoist Expr does not have to computed into a specific register,

Change the weights of GT_CNS_INT for ARM64

Don't auto retry when using the AltJit as that results in two copies of every method in the output file

Implementation of CSE for GT_CNS_INT using a single CSE for constant values that differ only in the low 12 bits.

Fix for JitDisableConstCSE() == 3

In CSE added check for mismatched types on GT_CNS_INT nodes

Fix assert divMod->markedMagicNumberDivision()

Propagate the gtFlags for a gtCallAddr node

Propagating a constant may create an opportunity to use a magic number division

Only perform conversion of floating point GT_DIV to an exact reciprocal GT_MUL when fgGlobalMorph is true

Mark the non-standard virtual stub indirection address arg with GTF_DONT_CSE

Changes for config variable JitDisableConstCSE - remove values 4 and 5

Allow CSE of the R2R indirect param constant address

Fix Assertion failed 'isValidGeneralDatasize(size)'

Change gtCostEx for 8-byte constants on AMD64 to be 2 so that they are CSE candidates

Workaround for ARM32 assert when CSE of Consts is enabled

Add a simple sort to compute the best shared const CSE's to use for the definition, sets csdConstDefValue and csdConstDefVN

Fix the gtCost GT_CNS_LNG for ARM32

Update arm32 GT_CNS costs.

Fix in AssertionProp for JitStress issue with beq_r8 test

Added additional Priority 0 test coverage for Floating Point optimizations