Skip to content

Define Debugger.IsSupported feature switch to allow trimming of debugger only code. #37288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marek-safar merged 1 commit into from
Jul 10, 2020
Merged

Define Debugger.IsSupported feature switch to allow trimming of debugger only code. #37288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/libraries/Microsoft.CSharp/src/ILLinkTrim.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
<linker>
<assembly fullname="Microsoft.CSharp">
<!-- Required for COM event dispatch -->
<type fullname="System.Runtime.InteropServices.ComEventsSink"/>
</assembly>

<assembly fullname="Microsoft.CSharp" feature="System.Diagnostics.Debugger.IsSupported" featurevalue="true" featuredefault="true">
<!-- Required by the Expression Evaluator -->
<type fullname="Microsoft.CSharp.RuntimeBinder.DynamicMetaObjectProviderDebugView"/>
<!-- Required by the Expression Evaluator -->
<type fullname="Microsoft.CSharp.RuntimeBinder.DynamicMetaObjectProviderDebugView/DynamicDebugViewEmptyException"/>
<!-- Required for COM event dispatch -->
<type fullname="System.Runtime.InteropServices.ComEventsSink"/>
</assembly>
</linker>
</linker>
4 changes: 2 additions & 2 deletions src/libraries/System.Linq/src/ILLinkTrim.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<linker>
<assembly fullname="System.Linq">
<assembly fullname="System.Linq" feature="System.Diagnostics.Debugger.IsSupported" featurevalue="true" featuredefault="true">
<!-- required by debugger, see comment in System/Linq/DebugView.cs -->
<type fullname="System.Linq.SystemCore_EnumerableDebugView" />
<type fullname="System.Linq.SystemCore_EnumerableDebugView`1" />
<type fullname="System.Linq.SystemCore_EnumerableDebugViewEmptyException" />
</assembly>
</linker>
</linker>
17 changes: 10 additions & 7 deletions src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,16 @@
<!-- Internal API used by tests only. -->
<method name="GetICUVersion" />
</type>
<!-- Properties and methods used by a debugger. -->
<type fullname="System.Threading.ThreadPoolBoundHandle">
<!-- Workaround to keep .interfaceimpl even though this type
is not instantiated on unix:
https://github.com/mono/linker/pull/649 -->
<method name=".ctor" />
</type>
</assembly>

<!-- Properties and methods used by a debugger. -->
<assembly fullname="System.Private.CoreLib" feature="System.Diagnostics.Debugger.IsSupported" featurevalue="true" featuredefault="true">
<type fullname="System.Threading.Tasks.Task">
<property name="ParentForDebugger" />
<property name="StateFlagsForDebugger" />
Expand Down Expand Up @@ -37,11 +46,5 @@
<!-- Methods is used by VS Tasks Window. -->
<method name="GetActiveTaskFromId" />
</type>
<type fullname="System.Threading.ThreadPoolBoundHandle">
<!-- Workaround to keep .interfaceimpl even though this type
is not instantiated on unix:
https://github.com/mono/linker/pull/649 -->
<method name=".ctor" />
</type>
</assembly>
</linker>