Skip to content

Disable GetAsync_UnicodeHostName_SuccessStatusCodeInResponse - #37487

Merged
alnikola merged 3 commits into
dotnet:masterfrom
alnikola:alnikola/increase-timeout-getunicodehostname
Jun 9, 2020
Merged

Disable GetAsync_UnicodeHostName_SuccessStatusCodeInResponse#37487
alnikola merged 3 commits into
dotnet:masterfrom
alnikola:alnikola/increase-timeout-getunicodehostname

Conversation

@alnikola

@alnikola alnikola commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

SocketsHttpHandlerTest_HttpClientHandlerTest_Http2.GetAsync_UnicodeHostName_SuccessStatusCodeInResponse is periodically failing with TimeoutException. It seems to be caused by the target server unavailability, this PR disables the test until a new unicode test host is found.

@ghost

ghost commented Jun 5, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@alnikola

alnikola commented Jun 5, 2020

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@stephentoub

Copy link
Copy Markdown
Member

this PR increases timeout to 200 sec.

Isn't this the test where we've found that the site is sometimes just down? I'm not sure increasing the timeout is going to help.

@stephentoub

Copy link
Copy Markdown
Member

#29424

@davidsh

davidsh commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

I was under the impression that this test was already disabled as a result of #29424 issue. That's why it is marked 'disabled-test'. But apparently this test wasn't actually disabled.

So, I think this PR should be changed to simply disable this test. It's useless increasing the timeout.

@davidsh

davidsh commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

And the future plan for this test was discussed at a previous team meeting.

Summary:

As we discussed in the team meeting, we plan to move this test to either a unicode DNS server that we own (similar to our other Azure servers) or move this test to a different pipeline like the runtime-libraries enterprise-linux pipeline which has Linux docker images in its own network and can use custom DNS. I was going to work on this test later.

Comment thread src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs Outdated
@alnikola alnikola changed the title GetAsync_UnicodeHostName_SuccessStatusCodeInResponse timeout set to 200 sec Disable GetAsync_UnicodeHostName_SuccessStatusCodeInResponse Jun 9, 2020
@alnikola alnikola added the disabled-test The test is disabled in source code against the issue label Jun 9, 2020
@alnikola
alnikola merged commit db70edd into dotnet:master Jun 9, 2020
@alnikola
alnikola deleted the alnikola/increase-timeout-getunicodehostname branch June 9, 2020 11:57
@davidsh davidsh removed the disabled-test The test is disabled in source code against the issue label Jun 9, 2020
@davidsh davidsh added this to the 5.0 milestone Jun 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants