Skip to content

Disable native varargs for Windows arm - #38147

Merged
kunalspathak merged 6 commits into
dotnet:masterfrom
kunalspathak:argiterator
Jun 19, 2020
Merged

Disable native varargs for Windows arm#38147
kunalspathak merged 6 commits into
dotnet:masterfrom
kunalspathak:argiterator

Conversation

@kunalspathak

@kunalspathak kunalspathak commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

Disable native varargs for Windows arm so ArgsIterator throws PlatformNotSupported exception. Also re-enable the test that was disabled in #35690.

Fixes: #35754

@Dotnet-GitSync-Bot

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label.

Comment thread src/coreclr/src/jit/target.h Outdated
Comment thread src/coreclr/src/jit/target.h Outdated
@kunalspathak
kunalspathak marked this pull request as ready for review June 19, 2020 20:52
@kunalspathak

Copy link
Copy Markdown
Contributor Author

Manually triggered runtime pipeline and leg "Libraries Test Run release coreclr Windows_NT arm Release" passed.
Merging because the last commit is formatting.

@kunalspathak
kunalspathak merged commit 7d5dd34 into dotnet:master Jun 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArgIteratorTests.ArgIterator_Throws_PlatformNotSupportedException test fails on Windows ARM

3 participants