Migrate coreclr's worker thread pool to be able to use the portable thread pool in opt-in fashion - #38225

Merged

kouvel merged 48 commits into

dotnet:masterfrom

kouvel:ThreadPool

Oct 21, 2020

Commits on Oct 20, 2020

Add dependencies
Koundinya Veluri
committed
Add config var
Koundinya Veluri
committed
Move portable RegisteredWaitHandle implementation to shared ThreadPool.cs
Koundinya Veluri
committed
Merge RegisteredWaitHandle implementations
Koundinya Veluri
committed
Separate portable-only portion of RegisteredWaitHandle
Koundinya Veluri
committed
Fix timers, tiered compilation, introduced time-sensitive work item queue to simulate coreclr behavior
Koundinya Veluri
committed
Implement ResetThreadPoolThread, set thread names for diagnostics
Koundinya Veluri
committed
Cache-line-separate PortableThreadPool._numRequestedWorkers similarly to coreclr
Koundinya Veluri
committed
Post wait completions to the IO completion port on Windows for coreclr, similarly to before
Koundinya Veluri
committed
Reroute managed gate thread into unmanaged side to perform gate activites, don't use unmanaged gate thread
Koundinya Veluri
committed
Flow config values from CoreCLR to the portable thread pool for compat
Koundinya Veluri
committed
Port - 44970522045f0c323f5735c4fe4b54bd8f71e800 - Fix hill climbing float overflow (dotnet/coreclr#14505)
Koundinya Veluri
committed
Port - aa5ce2b1bc9ac553ddd493e269a53c999d61e965 - Limit min threads in thread pool to 1 (dotnet/coreclr#14864)
Koundinya Veluri
committed
Port - 8cc2aa35933677339b9e9ec5485754aa750907df - Optimize AdjustMaxWorkersActive (#1103)
Koundinya Veluri
committed
Fix ETW events
Koundinya Veluri
committed
Fix perf of counts structs
Koundinya Veluri
committed
Fix perf of dispatch loop
Koundinya Veluri
committed
Fix perf of ThreadInt64PersistentCounter
Koundinya Veluri
committed
Miscellaneous perf fixes
Koundinya Veluri
committed
Fix starvation heuristic
Koundinya Veluri
committed
Implement worker tracking
Koundinya Veluri
committed
Use smaller stack size for threads that don't run user code
Koundinya Veluri
committed
Note some SOS dependencies, small fixes in hill climbing to make equivalent to coreclr
Koundinya Veluri
committed
Port some tests from CoreRT
Koundinya Veluri
committed
Fail-fast in thread pool native entry points specific to thread pool implementations based on config
Koundinya Veluri
committed
Fix SetMinThreads() and SetMaxThreads() to return true only when both changes are successful with synchronization
Koundinya Veluri
committed
Fix registered wait removals for fairness since there can be duplicate system wait objects in the wait array
Koundinya Veluri
committed
Allow multiple DotNETRuntime event providers/sources in EventPipe
Koundinya Veluri
committed
Fix registered wait handle timeout logic in the wait thread
Koundinya Veluri
committed
Fix Browser build
Koundinya Veluri
committed
Remove unnecessary methods from Browser thread pool, address some feedback
Koundinya Veluri
committed
Fix build warning after merge
Koundinya Veluri
committed
Address feedback for events, undo EventPipe change in mono, change event source name in mono, add comments
Koundinya Veluri
committed
Disable new timer test for browser
Koundinya Veluri
committed
Fix EventSource tests to expect the new provider name used in mono
Koundinya Veluri
committed
Revert event source name in mono to match coreclr
Koundinya Veluri
committed
Add issue link for prerequisites of enabling the portable thread pool by default
Koundinya Veluri
committed
Address feedback
Koundinya Veluri
committed
Fix race condition in registered wait unregister
Koundinya Veluri
committed
Fix a new issue in WaitThread after shifting items in arrays
Koundinya Veluri
committed
Fix usage of LowLevelMonitor after rebase
Koundinya Veluri
committed
Fix tests that use RemoteExecutor to include a test for whether it is supported, fix assert for browser builds
Koundinya Veluri
committed
Fix build
Koundinya Veluri
committed
Slight fix to starvation heuristic to be closer to what it was before
Koundinya Veluri
committed
Fix license headers in new files
Koundinya Veluri
committed
Address feedback
Koundinya Veluri
committed
Change pattern for accessing the event source for better ILLinker compatibility
Koundinya Veluri
committed
Move hill climbing config reads into constructor instead of passing them as parameters
Koundinya Veluri
committed