Skip to content

Fix Http test failure because of Activity Id Format default change. - #38363

Merged
tarekgh merged 2 commits into
dotnet:masterfrom
tarekgh:FixHttpTestFailure
Jun 25, 2020
Merged

Fix Http test failure because of Activity Id Format default change.#38363
tarekgh merged 2 commits into
dotnet:masterfrom
tarekgh:FixHttpTestFailure

Conversation

@tarekgh

@tarekgh tarekgh commented Jun 24, 2020

Copy link
Copy Markdown
Member

Fixes #38205

@ghost

ghost commented Jun 24, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tarekgh, @safern, @krwq
Notify danmosemsft if you want to be subscribed.

@ghost

ghost commented Jun 24, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@tarekgh

tarekgh commented Jun 24, 2020

Copy link
Copy Markdown
Member Author

CC @stephentoub @noahfalk

@tarekgh

tarekgh commented Jun 25, 2020

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@stephentoub

Copy link
Copy Markdown
Member

Should I be concerned about this as an indication that the activity change is a larger breaking change than anticipated?

@tarekgh

tarekgh commented Jun 25, 2020

Copy link
Copy Markdown
Member Author

Should I be concerned about this as an indication that the activity change is a larger breaking change than anticipated?

From what I am seeing is now storing more stuff as W3C Id format became a default. so I expect the breaking wouldn't be big in such cases (I guess). NCL may talk about this scenario better.

CC @karelz who may loop other guys can talk about that. to get @karelz up to speed, we have changed the Activity Id default Format from Heiraracal to W3C, and Http logs more info in the harder when having W3C format (e.g. transparent and tracestate fields). we have a config switch to get back the old behavior if necessary.

@noahfalk @shirhatti do you have any more input here?

@tarekgh

tarekgh commented Jun 25, 2020

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@noahfalk

Copy link
Copy Markdown
Member

Certainly there is some risk involved in making the breaking change, but this issue didn't change my assessment of it if that helps at all : )

@tarekgh

tarekgh commented Jun 25, 2020

Copy link
Copy Markdown
Member Author

The failures including the outerloop failures are not related. Also, this PR is addressed all Http test failures. I am going to merge this one.

@tarekgh
tarekgh merged commit 099dd84 into dotnet:master Jun 25, 2020
@tarekgh
tarekgh deleted the FixHttpTestFailure branch June 25, 2020 17:02
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.

5 participants