Skip to content

Add examples of System.Private.CoreLib iterative workflow - #38885

Merged
safern merged 3 commits into
dotnet:masterfrom
safern:CoreLibIterativeExample
Jul 7, 2020
Merged

Add examples of System.Private.CoreLib iterative workflow#38885
safern merged 3 commits into
dotnet:masterfrom
safern:CoreLibIterativeExample

Conversation

@safern

@safern safern commented Jul 7, 2020

Copy link
Copy Markdown
Member

cc: @danmosemsft @stephentoub

@Dotnet-GitSync-Bot

Dotnet-GitSync-Bot commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern

safern commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

Oops, missed to update build.sh, will update that.

danmoseley
danmoseley reviewed Jul 7, 2020
View reviewed changes
Comment thread docs/workflow/building/libraries/README.md
danmoseley
danmoseley reviewed Jul 7, 2020
View reviewed changes
Comment thread eng/build.ps1 Outdated
danmoseley
danmoseley reviewed Jul 7, 2020
View reviewed changes
Comment thread eng/build.sh Outdated
stephentoub
stephentoub approved these changes Jul 7, 2020
View reviewed changes

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Dan's comments, LGTM. Thanks.

@ViktorHofer

ViktorHofer commented Jul 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

FWIW we should start binplacing CoreLib (and optionally crossgen it) so that these manual steps aren't necessary. cc @ericstj

Related #38034

@safern

safern commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

FWIW we should start binplacing CoreLib (and optionally crossgen it) so that these manual steps aren't necessary

We should be careful when doing that because if CoreLib is built via a P2P and the configuration for CoreLib is Debug, but the runtime was built in release, there will be a configuration miss match in between CoreLib and runtime and I believe that is not allowed.

@ViktorHofer

ViktorHofer commented Jul 7, 2020

Copy link
Copy Markdown
Member

configuration miss match in between CoreLib and runtime and I believe that is not allowed.

@jkotas is mixing configurations between the runtime and CoreLib problematic? I assume not...

@safern
safern merged commit 792fd1d into dotnet:master Jul 7, 2020
@safern
safern deleted the CoreLibIterativeExample branch July 7, 2020 20:19
@jkotas

jkotas commented Jul 7, 2020

Copy link
Copy Markdown
Member

@jkotas is mixing configurations between the runtime and CoreLib problematic?

Yes, it is problematic. Layout of some data structures embedded in CoreLib is different between debug and release.

@safern safern mentioned this pull request Aug 4, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes
@ViktorHofer ViktorHofer ViktorHofer approved these changes
+1 more reviewer
@danmoseley danmoseley danmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@safern @Dotnet-GitSync-Bot @ViktorHofer @jkotas @stephentoub @danmoseley