Move Font*, Image* and Margins converters to System.Drawing.Common and apply Unit and Name converter - #40825
Conversation
|
Tagging subscribers to this area: @safern, @tannergooding |
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Touching ref assemblies but not adding new API. |
74ab92c to
8554791
Compare
This project still builds for netcoreapp3.0. Do we need to handle this specially? Refers to: src/libraries/System.Windows.Extensions/ref/System.Windows.Extensions.csproj:3 in 8554791. [](commit_id = 8554791, deletion_comment = False) |
Not really because it is not part of the shared framework and the typeforwards are yo System.Drawing.Common which will be in the netcoreapp3.0 implementation as well which is not inbox either, so it will have a PackageReference to System.Drawing.Common so it would work fine. |
Fixes: #33061
Fixes: #1011
cc: @DustinCampbell @merriemcgaw @RussKie
@Anipik I'm using the old Generate PNSE exclude API list attribute here.