Use Roslyn apis to generate Platform Not Supported Assemblies (#40296) - #40961
Merged
Conversation
* fixes on the runtime side * address feedback * update arcade version * merge conflicts * update the version
|
Tagging subscribers to this area: @safern, @ViktorHofer |
safern
reviewed
Aug 18, 2020
| <Compile Include="TypeForwards.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(TargetsWindows)' == 'true'"> | ||
| <Compile Include="TypeForwards.cs" /> |
Member
There was a problem hiding this comment.
The typeforwards need to be on both code paths right? So that the generate reference source doesn't generate a PNSE for those?
Contributor
Author
There was a problem hiding this comment.
The typeforwards need to be on both code paths right?
Correct. It will be taken from ref in case of geneartePlatformNotSupported case.
So that the generate reference source doesn't generate a PNSE for those?
generate not supported assembly will not be doing anything to typeforwards, will just copy them to the intermediate folder and compile.
Contributor
|
Port approved |
safern
approved these changes
Aug 18, 2020
Contributor
Author
|
Failure is unreleated |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR #40296
Original Issue #33631