Fix GetAppdomainStaticAddress for non-collectible assemblies#41076
Conversation
|
Tagging subscribers to this area: @tommcdon |
|
@hoyosjs there are a couple failures with "cmd is not recognized as an internal or external command" like https://dev.azure.com/dnceng/public/_build/results?buildId=781079&view=ms.vss-test-web.build-test-results-tab&runId=24584748&resultId=101778&paneView=debug Is this a known issue? |
Yes, this is https://github.com/dotnet/core-eng/issues/10586 |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/222712648 |
|
There was a test failure in a recent outerloop, is it a known issue? |
|
@sandreenko no that is not a known issue. Looking at the logs it's not a failure I would expect to see either. I'll try and dig a little deeper but I suspect that this is a one off thing I won't be able to investigate |
Fixes #40954
#34677 had a bug in it that it would check if pModule->GetLoaderAllocator()->GetExposedObject was NULL, which is the right thing to check for collectible modules but non-collectible modules it will always be NULL.