Skip to content

Fix half equality method - #41259

Merged
pgovind merged 2 commits into
dotnet:masterfrom
huoyaoyuan:half-equals
Aug 24, 2020
Merged

Fix half equality method#41259
pgovind merged 2 commits into
dotnet:masterfrom
huoyaoyuan:half-equals

Conversation

@huoyaoyuan

Copy link
Copy Markdown
Member

Fixes #41258

The implementation may not be fully optimal, but I copied the semantics from double.
Relevant test added.

@ghost

ghost commented Aug 24, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tannergooding, @pgovind
See info in area-owners.md if you want to be subscribed.

@danmoseley
danmoseley requested a review from pgovind August 24, 2020 21:33
@danmoseley danmoseley added this to the 5.0.0 milestone Aug 24, 2020

@pgovind pgovind left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! LGTM!

@pgovind

pgovind commented Aug 24, 2020

Copy link
Copy Markdown

Passes CI, merging.

@pgovind
pgovind merged commit 88d2ab8 into dotnet:master Aug 24, 2020
@pgovind

pgovind commented Aug 24, 2020

Copy link
Copy Markdown

I'll submit a PR shortly to port this to 5.0

@pgovind

pgovind commented Aug 24, 2020

Copy link
Copy Markdown

/backport to release/5.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/222711902

@huoyaoyuan
huoyaoyuan deleted the half-equals branch August 25, 2020 04:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Semantics of Equals is different for System.Half comparing to other floating point types

5 participants