[release/5.0] Port API fixes for single file apps#41385
Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Also adds test for Module.FullyQualifiedName (cherry picked from commit 0546bd5)
agocke
changed the title
|
Tagging subscribers to this area: @swaroop-sridhar, @agocke |
Member
|
Approved. Please fill out the template, get a cr, and a clean ci. |
jeffschwMSFT
approved these changes
Aug 26, 2020
agocke
changed the title
mateoatr
approved these changes
Aug 26, 2020
vitek-karas
approved these changes
Aug 26, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41019 and #40974 to release/5.0
/cc @agocke @mateoatr
Customer Impact
This PR fixes two APIs: GetCommandLineArgs and CodeBase. GetCommandLineArgs is changed such that the first argument is a path to the single-file binary, instead of the non-existent entry point module path. CodeBase is changed to throw instead of return a file that doesn't exist on disk.
The prior behavior of these APIs is incorrect and is corrected for 6.0. Backporting these fixes prevents confusion and later breaking changes.
Testing
Unit tests have been added for the behavior of these APIs in single file bundles.
Risk
Low. These changes only affect new (bundle) single-file scenarios, and are constrained to the specific APIs being changed, one of which is obsolete.