[release/5.0-rc2] Fix ldtoken for generic RuntimeMethodHandle - #42141
Merged
Conversation
ldtoken for generic RuntimeMethodHandle in non-generic method triggered generic dictionary lookup due to normalization of MethodDescs for reflection. It lead to InvalidProgramException later. Fixes #41674
jkotas
added
area-CodeGen-coreclr
jeffschwMSFT
approved these changes
Sep 11, 2020
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. I will take it for RC2 consideration
davidwrighton
approved these changes
Sep 11, 2020
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #42112 to release/5.0-rc2
Fixes #41674
/cc @jkotas
Customer Impact
Regression from 3.1. Introduce by .NET 5 codegen optimizations.
System.Linq.Expression referencing interface method on a generic throws InvalidProgramException.
Testing
Risk
Low