[release/5.0] Extract bundled files when IncludeAllContentForSelfExtract is set#42934
Merged
agocke merged 2 commits intoOct 2, 2020
Merged
Conversation
…tnet#42435) Backport of dotnet#42435 to release/5.0. (cherry picked from commit 0be66cb)
Dotnet-GitSync-Bot
added
the
area-Infrastructure-coreclr
|
Tagging subscribers to this area: @agocke |
agocke
changed the title
This was referenced Oct 1, 2020
Member
|
Are we going to merge with the other PR about native libs as well? |
jeffschwMSFT
added
Servicing-consider
jeffschwMSFT
approved these changes
Oct 1, 2020
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Please get crs and add the customer impact in the description. We should consider this for GA
leecow
added
Servicing-approved
agocke
changed the title
Member
Author
|
@vitek-karas Yes, I'm going to add the commit from #42876 once that is merged |
) Add two directories to NATIVE_DLL_SEARCH_DIRECTORIES to single-file bundles: 1. The bundle exe directory 2. If the bundle extracts any files, the extraction directory Fixes dotnet#42772 (cherry picked from commit 0403018)
Member
Author
|
This should be up to date and ready for final review |
vitek-karas
approved these changes
Oct 2, 2020
elinor-fung
approved these changes
Oct 2, 2020
mateoatr
approved these changes
Oct 2, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #42435 to release/5.0.
This change fixes the "3.1 compat mode" for single-file. This flag allows people to return to the previous "extraction" behavior of single-file that was available in 3.1.
Customer impact
In certain scenarios, like use of changed APIs in a dependent library, this may be the only workaround for users who were previously using the 3.1 version of single-file. In compat testing, we found as many as half of the applications which worked with single-file were broken with the 5.0 changes.
Regression
The 3.1 -> 5.0 mode was an intentional breaking change, and this mode was intended to be present to mitigate the break.
Testing
Manual testing of all of the app compat libraries, both in the compat scenario, and in 5.0 after the compat fix.
Risk
This change is entirely in single-file. It is a large change and bares moderate risk, but the risk would be isolated to single-file publishing.
(cherry picked from commit 0be66cb)