Teach coreclr/src/tools about Checked configuration

[MichalStrehovsky]

We never test managed tools in Debug configuration because we never build the runtime partition in the Debug configuration - we only build Checked.

But managed tools don't know what Checked means because it's not an MSBuild concept. So we never run the tools with asserts turned on.

[ghost]

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

[MichalStrehovsky]

Cc @dotnet/crossgen-contrib. This mostly affects crossgen2. Some other managed tools also do Debug.Assert, but crossgen2 is likely going to be most problematic.

/azp run runtime-coreclr crossgen2

[MichalStrehovsky]

/azp run runtime-coreclr crossgen2

[azure-pipelines]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

[MichalStrehovsky]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Thanks for nothing azure-pipelines. I triggered it manually here: https://dev.azure.com/dnceng/public/_build/results?buildId=841304&view=results

[trylek]

For the inability to use /azp run to trigger general pipelines like CG2, I have a PR out to fix this, it's just waiting on code review right now:

#42933

[MichalStrehovsky]

@trylek do the crossgen2 failures look about expected? I don't see an obvious assert being hit.

[trylek]

Hmm, the "incomplete instantiation in GetArrayDataReference" is a known issue unrelated to your change. It started reproing around September 25, JanV originally speculated that it might be related to a small semantical change he inadvertently made when switching over framework compilation using crossgen2 to use r2rtest; but he's already fixed that and apparently the bugs are still there. I'm investigating them now as I believe that to be our largest CQ regression in quite a while.

[AaronRobinsonMSFT]

This looks good to me. I don't know if there are other properties we need to update but this seems like a good start.

/cc @jkoritzinsky

[jkotas]

@trylek Are the crossgen2 failures known issues? Can this be merged?

[trylek]

@jkotas - Hmm, I cannot access the AzDO page for the CG2 run, it claims that "Page not found". I'll retry in a bit to see whether it's just temporary hiccup, otherwise I see no other way of double-checking CG2 results than rerunning the CG2 job.

[trylek]

OK, let me put it like this: the CG2 failures don't seem related to this change so I believe it's safe to merge.