Enable building .NET Core osx-arm64 in CI by sdmaclea · Pull Request #43187 · dotnet/runtime

sdmaclea · 2020-10-08T20:51:56Z

Enables building of .NET Core osx-arm64

ghost · 2020-10-08T20:52:00Z

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

hoyosjs · 2020-10-08T22:39:23Z

@@ -1,5 +1,10 @@
 #!/usr/bin/env bash

+if [ "$1" = "OSX" ] && [ "$2" = "arm64" ]; then


Not sure this is a great place to begin doing this. This should probably go in the yaml as it's tied to AzDO pools, and in documentation we should specify it as a dependency for osx-arm64.

I'm not sure I understand the rationale. Isn't this file just for installing dependencies for CI.

Yeah, this just feels like hiding things in scripts. This is not an installation. At least it's not obvious to me that an installation script hardcodes a path to something that's only true in AzDO (for example, what if a customer runs this expecting to brew install the deps in their box).

@hoyosjs & I are in disagreement here... Any other opinions... Before we try to drive to consensus?

The build step that calls this is called Install Build Dependencies. It seems logical to configure dependencies here too. If we must I can add another configure dependencies step, but it seems overkill.

azdo seems overly specific. Are you OK with setup-native-dependencies-4ci.sh & Setup Build Dependencies?

I chose azdo just because it's that: the xcode path for AzDO agents. It's not the same path as helix test agents necessarily or anything (my box doesn't have that path even though I use the same version of XCode now). However, I don't feel too strongly, mostly care about "setup" and "ci/not-local".

Wouldn't be people that run this to help them set native dependencies locally?

I hadn't seen any instructions suggesting using this for developer setup.

Edit:
~~I guess since this is likely temporary I can just make it a separate build step.~~

I added azDO to the CI install-native-dependencies.sh command line and made the xcode-select conditional on the azDO argument. I also added brief header comments.

I initial went down the path of renaming install -> setup, but I felt like it added confusion. setup in my mind doesn't imply install. However setup/configurations is a subset of install. So I reverted it all and went with this approach.

Hope this is a satisfactory compromise.

hoyosjs · 2020-10-08T22:50:17Z

Also unclear if related, somehow we ended with this job:

  - job: installer_coreclr__OSX_arm64_Release
    displayName: Installer Build and Test coreclr  OSX_arm64 Release
    dependsOn:
    - checkout
    - coreclr__product_build_OSX_arm64_release
    - libraries_build_OSX_arm64_Debug

@safern do release tests for installer depend on debug libraries bits?

hoyosjs · 2020-10-08T22:57:00Z

The error remaining is just we are missing passing the architecture to the installer part of the build. The autodetection thinks it's x64 (given that's the host's architecture).

safern · 2020-10-08T23:27:00Z

@safern do release tests for installer depend on debug libraries bits?

In PR some of them do, because we build some flavors of libraries in Debug on PR and Release for CI and official build.

There is a variable that controls this... debugOnPrReleaseOnRolling
.https://github.com/dotnet/runtime/blob/master/eng/pipelines/runtime.yml#L617

sdmaclea · 2020-10-09T18:28:38Z

I am running an internal build of this here https://dev.azure.com/dnceng/internal/_build/results?buildId=847071&view=results. I suspect I will need to add something additional to publish the new packages, but that could be a subsequent PR.

sdmaclea · 2020-10-09T21:30:51Z

Looks like the internal build completed fine. Looks to me (a novice) like the osx-arm64 packages are properly publishing.

CI on this PR and the internal run are green. This is ready for a final review.

mangod9

Thanks for enabling this.

hoyosjs · 2020-10-09T21:37:34Z

The Runtime packs look good to me
The assemblies are crossgen'd and all.

sdmaclea · 2020-10-09T21:50:37Z

I'm going to merge this. I'll work on a follow up PR to add the crossBuild parameter.

If there is anything else which you would like resolved. Feel free to comment on this or that PR, and I will work to get it resolved.

sdmaclea · 2020-10-09T22:03:30Z

/cc @richlander This should enable nightly runtime osx-arm64 builds.

safern · 2020-10-09T23:12:22Z

          - Linux_arm64
          - Linux_musl_arm64
      - ${{ if eq(variables['includeOsxOuterloop'], true) }}:        
+        - OSX_arm64


I should've caught this... I think we don't have a helix queue setup for OSX_arm64, so I guess this broke the libraries outerloop build. I can fix this in a separate PR and we can enable them once we have a queue for it.

since we still dont have stable hardware for this we dont expect to enable test runs for osx_arm64 just yet. Can we leave it disabled till we have that?

Yeah, I created a PR for that: #43242

cool.. thanks.

I should've caught this...

@safern Thanks for being genereous, but this was clearly my fault. I forget there are three main pipelines all the time. I get the rolling outerloop and the official build pipeline confused and map them to a single pipeline...

Yeah, we have so many ymls that it is sometimes hard to get it right and the easier way to add a new flavor is to try and look where we're already building osx_x64 and just add entries for the new platform there, so confusing for all I think 😄

safern

This didn't enable mono on that new platform. @akoeplinger @steveisok do we want to do that?

Overall looks good to me. Thanks for doing this @sdmaclea

Enable building .NET Core osx-arm64 in CI

20aac13

sdmaclea added arch-arm64 area-Infrastructure os-macos-bigsur (macOS11) labels Oct 8, 2020

sdmaclea added this to the 6.0.0 milestone Oct 8, 2020

sdmaclea requested review from hoyosjs, janvorli and safern October 8, 2020 20:51

sdmaclea self-assigned this Oct 8, 2020

sdmaclea commented Oct 8, 2020

View reviewed changes

Comment thread eng/pipelines/common/platform-matrix.yml Outdated

mangod9 reviewed Oct 8, 2020

View reviewed changes

Comment thread eng/pipelines/common/xplat-setup.yml

For osx-arm64 xcode-select xcode_12.2

2e72c12

sdmaclea force-pushed the dev/Arm64MacOS branch from 1caab77 to 2e72c12 Compare October 8, 2020 21:51

hoyosjs reviewed Oct 8, 2020

View reviewed changes

sdmaclea added 2 commits October 8, 2020 19:22

Use vmImage macOS-10.15 for all platforms

2a369a5

Don't use crossrootfsDir to determine if it is a crossBuild

cb67462

safern reviewed Oct 8, 2020

View reviewed changes

Comment thread eng/pipelines/installer/jobs/base-job.yml Outdated

sdmaclea added 2 commits October 8, 2020 19:52

Fix osx-arm64 installer builds

2a4df7f

Allow dev use of eng/install-native-dependencies.sh

3067150

mangod9 approved these changes Oct 9, 2020

View reviewed changes

sdmaclea merged commit 2a52f75 into dotnet:master Oct 9, 2020

safern reviewed Oct 9, 2020

View reviewed changes

BruceForstall mentioned this pull request Nov 2, 2020

runtime-coreclr outerloop pipeline failing osx-arm64 job #44158

Closed

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

		@@ -1,5 +1,10 @@
		#!/usr/bin/env bash

		if [ "$1" = "OSX" ] && [ "$2" = "arm64" ]; then

Uh oh!

Conversation

sdmaclea commented Oct 8, 2020

Uh oh!

ghost commented Oct 8, 2020

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdmaclea Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoyosjs commented Oct 8, 2020

Uh oh!

hoyosjs commented Oct 8, 2020

Uh oh!

safern commented Oct 8, 2020

Uh oh!

Uh oh!

sdmaclea commented Oct 9, 2020

Uh oh!

sdmaclea commented Oct 9, 2020

Uh oh!

mangod9 left a comment

Choose a reason for hiding this comment

Uh oh!

hoyosjs commented Oct 9, 2020

Uh oh!

sdmaclea commented Oct 9, 2020

Uh oh!

sdmaclea commented Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

safern Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

safern left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sdmaclea Oct 9, 2020 •

edited

Loading

sdmaclea commented Oct 9, 2020 •

edited

Loading

safern Oct 9, 2020 •

edited

Loading