Skip to content

Implemented clock_gettime_nsec_np in libraries for Apple Silicon support - #43343

Merged
jkotas merged 3 commits into
dotnet:masterfrom
snickler:issue-43320
Oct 14, 2020
Merged

Implemented clock_gettime_nsec_np in libraries for Apple Silicon support#43343
jkotas merged 3 commits into
dotnet:masterfrom
snickler:issue-43320

Conversation

@snickler

Copy link
Copy Markdown
Contributor

Replaced mach_absolute_time with clock_gettime_nsec_np.
Replaced HAVE_MACH_ABSOLUTE_TIME directive with HAVE_CLOCK_GETTIME_NSEC_NP.

Fixes #43320

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-PAL-coreclr only for closed issues label Oct 13, 2020
Comment thread src/libraries/Native/Unix/System.Native/pal_time.c Outdated
Comment thread src/libraries/Native/Unix/System.Native/pal_time.c Outdated
Comment thread src/libraries/Native/Unix/System.Native/pal_time.c Outdated

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snickler

Copy link
Copy Markdown
Contributor Author

A big thanks to @vcsjones for some well needed explanations and help! ^_^

@snickler

Copy link
Copy Markdown
Contributor Author

Hm. @jkotas how do we make these tests run again? It seems that a few of them timed out.

@jkotas

jkotas commented Oct 14, 2020

Copy link
Copy Markdown
Member

All failures look like infrastructure issues. I have restarted the tests just to be sure.

@jkotas
jkotas merged commit d67cc2c into dotnet:master Oct 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclr only for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change libraries to use clock_gettime_nsec_np instead of mach_absolute_time

3 participants