Skip to content

Try a different attribute for disabling stream conformance tests on browser - #44218

Merged
stephentoub merged 1 commit into
masterfrom
stephentoub-patch-1
Nov 3, 2020
Merged

Try a different attribute for disabling stream conformance tests on browser#44218
stephentoub merged 1 commit into
masterfrom
stephentoub-patch-1

Conversation

@stephentoub

@stephentoub stephentoub commented Nov 3, 2020

Copy link
Copy Markdown
Member

Fixes #44214 hopefully?

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Nov 3, 2020
@steveisok

Copy link
Copy Markdown
Member

Do the skip attributes work on abstract classes? I may have fought that battle before and lost, but my memory is fuzzy as to where.

@stephentoub

stephentoub commented Nov 3, 2020

Copy link
Copy Markdown
Member Author

Do the skip attributes work on abstract classes?

I don't know. I'm trying to figure out why the existing attribution on there didn't prevent #44214 from happening.

@stephentoub
stephentoub merged commit 09a7d6c into master Nov 3, 2020
@stephentoub
stephentoub deleted the stephentoub-patch-1 branch November 3, 2020 22:09
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclr Only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BufferedAsyncFileStreamStandaloneConformanceTests.Read_EmptyStream_Nop_Success failing with PNSE

3 participants